Opened on 11/16/2017 at 11:26:12 AM
Closed on 11/16/2017 at 02:27:31 PM
Last modified on 11/30/2017 at 01:56:07 PM
#6046 closed defect (fixed)
[webextension] Mobile options page is zoomed out
| Reported by: | greiner | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.0.2-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | kzar, Ross, sebastian, trev | Blocked By: | |
| Blocking: | Platform: | Firefox Mobile | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
Nexus 5X
Android 8
Firefox 57
Adblock Plus 3.0.1
ALSO
Moto G4 Plus, Firefox 57b12, Adblock Plus 3.0.1, Android 7.0
How to reproduce
Open the Adblock Plus options page
Observed behaviour
The entire UI looks small and zoomed out. Zooming in manually changes the UI to look normal. (See attached screenshot.)
Expected behaviour
Text is legible and other parts of the UI also look normally sized.
Attachments (2)
Change History (11)
comment:1 Changed on 11/16/2017 at 11:28:52 AM by greiner
comment:2 Changed on 11/16/2017 at 01:55:15 PM by kzar
- Cc sebastian trev added
- Component changed from Unknown to Platform
- Description modified (diff)
- Platform changed from Unknown / Cross platform to Firefox Mobile
- Priority changed from Unknown to P2
- Ready set
- Summary changed from Mobile options page is zoomed out to [webextensions] Mobile options page is zoomed out
I can reproduce this.
Changed on 11/16/2017 at 01:55:42 PM by kzar
comment:3 Changed on 11/16/2017 at 01:59:11 PM by kzar
Oh, I was observing #5977 since that screenshot is of the popup UI. But when I click "Options" from the popup UI the options page is also zoomed out. I'll attach another screenshot.
Changed on 11/16/2017 at 02:01:19 PM by kzar
comment:4 Changed on 11/16/2017 at 02:17:10 PM by kzar
- Owner set to kzar
I think we just need to add the viewport meta tag to adblockpluschrome/options.html. I've just tried adding that in using USB debugging and it seemed to work OK.
comment:5 Changed on 11/16/2017 at 02:21:50 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 11/16/2017 at 02:26:59 PM by abpbot
A commit referencing this issue has landed:
Issue 6046 - Ensure mobile options page is zoomed correctly
comment:7 Changed on 11/16/2017 at 02:27:31 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 11/29/2017 at 08:11:50 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 3.0.1.1939
Firefox 57 / Galaxy J5 / Android 6.0.1
Firefox 57 / Iconia Tab 8 / Android 4.4.4
comment:9 Changed on 11/30/2017 at 01:56:07 PM by kzar
- Summary changed from [webextensions] Mobile options page is zoomed out to [webextension] Mobile options page is zoomed out
@Ross @kzar Can you reproduce this issue?
This used to work when we implemented it and AFAIK nothing has changed since then. Therefore I don't know yet whether this is an issue with the UI, the extension or the platform.