Opened on 11/16/2017 at 04:46:35 PM
Closed on 12/20/2017 at 06:19:24 PM
Last modified on 01/30/2018 at 06:51:54 PM
#6047 closed defect (fixed)
Missing background on uninstallation page
| Reported by: | greiner | Assignee: | juliandoucette |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | juliandoucette, jeen | Blocked By: | #6060, #6061 |
| Blocking: | #5711 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by juliandoucette)
Environment
Ubuntu 16.04
Chrome 62
How to reproduce
Go to https://adblockplus.org/en/uninstalled
Observed behaviour
White background
Expected behaviour
Background image exists OR new adblockplus.org design is applied to the page
Further information
This regression appears to have been introduced in #5633. While I assume that it's intentional that the uninstallation page doesn't have a background image anymore since we got rid of it throughout adblockplus.org, this page doesn't appear to be affected by the recent website redesign. Therefore the impact on this page may have been unintentional.
What to change
Apply the default template to this page.
Attachments (0)
Change History (8)
comment:1 Changed on 11/16/2017 at 06:04:22 PM by juliandoucette
- Cc jeen added
- Description modified (diff)
- Keywords goodfirstbug added
- Milestone set to adblockplus.org 2.0.0
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 11/17/2017 at 06:41:46 PM by juliandoucette
- Owner set to juliandoucette
#julianronit
I have come up with a new ~design myself. I will upload to review soon.
comment:3 Changed on 11/17/2017 at 07:11:28 PM by juliandoucette
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 11/20/2017 at 03:45:19 PM by juliandoucette
- Blocked By 6060, 6061 added
comment:5 Changed on 11/27/2017 at 06:35:34 PM by juliandoucette
- Blocking 5711 added
comment:6 Changed on 12/20/2017 at 06:17:31 PM by abpbot
A commit referencing this issue has landed:
Issue 6047 - Updated uninstall page designs
comment:7 Changed on 12/20/2017 at 06:19:24 PM by juliandoucette
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 01/30/2018 at 06:51:54 PM by juliandoucette
- Milestone adblockplus.org 2.0.0 deleted
Milestone adblockplus.org 2.0.0 deleted
It was intentional (by me). But Paul & Jeen want this to have the regular ABP header and footer IIRC. I haven't implemented this yet. We can use this ticket for that.