Opened on 11/22/2017 at 01:01:31 PM

Closed on 11/24/2017 at 12:24:22 PM

Last modified on 12/05/2017 at 10:59:13 AM

#6075 closed defect (fixed)

Hide Acceptable Ads notification when corresponding subscription is removed

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner, Ross, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29615620/

Description

Environment

Browser: Chrome or Firefox

How to reproduce

  1. Download adblockplusui repository and run the test server
  2. Click on Block additional tracking
  3. Observe
  4. Cick on Only allow ads without third-party tracking
  5. Observe

Observed behaviour

On step 3 a notification about Acceptable Ads is being shown, on step 5 it still persists

Expected behaviour

On step 5 no notification is shown

Attachments (0)

Change History (5)

comment:1 Changed on 11/22/2017 at 01:26:38 PM by saroyanm

  • Cc wspee added
  • Owner set to saroyanm
  • Summary changed from Remove Acceptable Ads notification when corresponding subscription is removed to Hide Acceptable Ads notification when corresponding subscription is removed

comment:2 Changed on 11/22/2017 at 01:31:37 PM by saroyanm

  • Review URL(s) modified (diff)

comment:3 Changed on 11/24/2017 at 12:22:57 PM by abpbot

comment:4 Changed on 11/24/2017 at 12:24:22 PM by saroyanm

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed on 12/05/2017 at 10:59:13 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Seems to work fine.

ABP 3.0.1.1939
Firefox 52 / 57 / Windows 10
Chrome 52 / 62 / Windows 7
Opera 39 / 49 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.