Opened on 11/22/2017 at 03:25:56 PM
Closed on 12/12/2017 at 02:37:55 PM
Last modified on 06/05/2018 at 11:12:35 PM
#6076 closed change (fixed)
Remove old search engine ordering logic
| Reported by: | jwangenheim | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.4.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | diegocarloslima, rjeschke, tpregueiro | Blocked By: | |
| Blocking: | #6077 | Platform: | Adblock Browser for Android |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by jwangenheim)
Background
The way how search engines are selected and sorted changed in Firefox 55. Due to this change we have to remove the old logic of ordering search engines for the ABB merge with Fennec 56.
What to change
Remove all the code from tranform_locales.py in mozharness for reading and writing list.txt for each locale. Mainly code in _transform_locale() and Constants
Attachments (0)
Change History (12)
comment:1 Changed on 11/22/2017 at 03:33:04 PM by jwangenheim
- Blocked By 6077 added
comment:3 Changed on 11/24/2017 at 12:07:31 AM by diegocarloslima
- Platform changed from Unknown / Cross platform to Adblock Browser for Android
comment:4 Changed on 12/01/2017 at 03:32:36 PM by jwangenheim
- Blocked By 6077 removed
- Description modified (diff)
comment:5 Changed on 12/01/2017 at 03:32:52 PM by jwangenheim
- Blocking 6077 added
comment:8 Changed on 12/08/2017 at 03:23:32 PM by abpbot
comment:9 Changed on 12/12/2017 at 02:36:27 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
comment:10 Changed on 12/12/2017 at 02:37:43 PM by diegocarloslima
- Status changed from new to reviewing
comment:11 Changed on 12/12/2017 at 02:37:55 PM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:12 Changed on 06/05/2018 at 11:12:35 PM by traynard
- Verified working set
Search engine list still sorts on it's own and retains all search engines in the list as expected.
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6076 - Remove old search engine ordering logic