Opened on 11/23/2017 at 04:28:22 PM

Closed on 11/23/2017 at 04:38:34 PM

Last modified on 12/05/2017 at 11:35:30 AM

#6085 closed defect (fixed)

Update adblockplusui dependency to revision 45ea4a1ff9f9

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords:
Cc: sebastian, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29616582/

Description

Background

When making changes to our developer tools pane (#6035) I changed the class name of requests listed there. Unfortunately I forgot to update that classname in the code used to filter the requests by a string which broke request filtering (#6084). I've fixed that now but we still need to update the adblockplusui dependency

What to change

Update the adblockplusui dependency to:

mercurial git
45ea4a1ff9f9 28d1ac1

No other changes will be included in the update.

Hints for testers

  • Check that request filtering in our developer tools pane works in Chrome. (See #6084 for more details.)

Attachments (0)

Change History (4)

comment:1 Changed on 11/23/2017 at 04:33:53 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/23/2017 at 04:36:42 PM by abpbot

comment:3 Changed on 11/23/2017 at 04:38:34 PM by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 12/05/2017 at 11:35:30 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done.

ABP 3.0.1.1939
Firefox 52 / 57 / Windows 7
Chrome 52 / 62 / Windows 10
Opera 39 / 49 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.