Opened on 11/14/2017 at 11:50:11 AM
Closed on 11/14/2017 at 06:06:16 PM
Last modified on 12/05/2017 at 11:15:31 AM
#6035 closed defect (fixed)
[webextension] Clicking items in the devtools pane doesn't work
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | sebastian, Ross, trev, greiner | Blocked By: | |
| Blocking: | #6038 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29607566/ |
||
Description (last modified by kzar)
Environment
Firefox 57, Windows 10, adblockpluschrome 02cd0e01c0ba
How to reproduce
- Open the devtools for a website, switch to the Adblock Plus pane.
- Refresh the page.
- Click one of the listed resources.
Observed behaviour
Nothing happens, an exception appears in the browser console:
TypeError: ext.devtools.panels.openResource is not a function devtools-panel.js:99:9
Expected behaviour
The resource is opened / displayed. An exception does not appear in the browser console.
Hints for testers
The resource clicked should be displayed in the devtools properly where the API is supported (Chrome) but open in a new tab otherwise (Firefox).
Attachments (0)
Change History (9)
comment:1 Changed on 11/14/2017 at 12:03:49 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/14/2017 at 03:17:55 PM by kzar
- Cc greiner added
- Component changed from Platform to User-Interface
- Priority changed from P2 to Unknown
- Ready unset
- Review URL(s) modified (diff)
comment:4 Changed on 11/14/2017 at 05:55:34 PM by greiner
- Priority changed from Unknown to P2
- Ready set
comment:5 Changed on 11/14/2017 at 06:02:05 PM by abpbot
comment:6 Changed on 11/14/2017 at 06:06:16 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 11/14/2017 at 06:11:44 PM by kzar
- Blocking 6038 added
comment:8 Changed on 11/15/2017 at 08:55:39 AM by trev
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1417346 to improve the usability of this solution in Firefox.
comment:9 Changed on 12/05/2017 at 11:15:31 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. In Firefox resources are opened in a new tab, in Chrome/Opera they open in the devtools.
ABP 3.0.1.1939
Firefox 52 / 57 / Windows 10
Chrome 52 / 62 / Windows 7
Opera 39 / 49 / Windows 7
A commit referencing this issue has landed:
Issue 6035 - Only use openResource API when it's supported