Opened on 11/30/2017 at 04:03:24 PM
Closed on 12/13/2017 at 10:39:39 AM
Last modified on 03/20/2018 at 09:07:21 AM
#6115 closed change (fixed)
Refactor icons
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | options-page |
| Cc: | greiner, ire | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29626565/ |
||
Description
Background
Currently we do not have unified styles for icons that make them hardly maintainable, this leads to issues like repeating background which cause SVG render issues in some places (ex.: #6089 checkbox background-image repeat, though it's partially chrome SVG resize bug).
What to change
- Unify SVG Icons styles
- use .icon class to apply consistent styles to elements containing icons
Attachments (0)
Change History (10)
comment:1 Changed on 11/30/2017 at 04:03:44 PM by saroyanm
- Keywords options-page added
- Owner set to saroyanm
comment:2 Changed on 12/01/2017 at 06:45:11 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 12/12/2017 at 10:55:18 AM by abpbot
comment:4 Changed on 12/12/2017 at 10:56:29 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 12/12/2017 at 11:03:36 AM by saroyanm
- Resolution fixed deleted
- Status changed from closed to reopened
I just noticed a small issue, with the Acceptable Ads notificaiton close icon, I think that can be tackled as part of this issue still.
comment:6 Changed on 12/12/2017 at 11:05:58 AM by saroyanm
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:7 Changed on 12/13/2017 at 10:39:14 AM by abpbot
A commit referencing this issue has landed:
Issue 6115 - Adjust Acceptable Ads notification close icon position
comment:8 Changed on 12/13/2017 at 10:39:39 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 02/08/2018 at 02:09:33 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Icons display and function as expected after changes.
ABP 3.0.2.1968
Firefox 51 / 58 / 59 / Windows 7
Firefox Mobile 57 / Android 7.0.1
comment:10 Changed on 03/20/2018 at 09:07:21 AM by Ross
Rechecked.
ABP 3.0.2.1983
Firefox Mobile 57 / Android 7.0.1
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 49 / Windows 7
A commit referencing this issue has landed:
Issue 6115 - Refactored icon classes