Opened on 11/28/2017 at 02:12:19 PM

Closed on 11/28/2017 at 03:05:06 PM

Last modified on 12/11/2017 at 09:56:52 AM

#6103 closed defect (fixed)

No attribute error when running build script

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner, kzar, sebastian, tlucas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29622588/

Description (last modified by saroyanm)

Environment

Python 2.7.6

How to reproduce

  1. Clone ​adblockplusui repository
  2. run python build.py -h
  3. Observe

Observed behaviour

The error below is being thrown and Info shown

INFO: Updating /home/saroyanm/projects/abp/adblockplusui/temp1/ensure_dependencies.py from /home/saroyanm/projects/abp/adblockplusui/temp1/buildtools/ensure_dependencies.py, don't forget to commit
INFO: Restarting /home/saroyanm/projects/abp/adblockplusui/temp1/ensure_dependencies.py

Traceback (most recent call last):
  File "build.py", line 18, in <module>
    buildtools.build.processArgs(BASE_DIR, sys.argv)
AttributeError: 'module' object has no attribute 'processArgs'

Expected behaviour

No error is thrown and INFO about uncommited changes

Note

This error started to be thrown after #6102.

Attachments (0)

Change History (8)

comment:1 Changed on 11/28/2017 at 02:14:59 PM by saroyanm

  • Description modified (diff)

Note: There are uncommitted changes that will be pushed as soon this is fixed (I assume we will need another dependency update in adblockplusui)

Last edited on 11/28/2017 at 02:15:20 PM by saroyanm

comment:2 Changed on 11/28/2017 at 02:31:51 PM by saroyanm

  • Component changed from Automation to User-Interface
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

The build.py need to be updated in order to reflect Integration notes in #6021

comment:3 Changed on 11/28/2017 at 02:32:17 PM by saroyanm

  • Owner set to saroyanm

comment:4 Changed on 11/28/2017 at 02:49:35 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 11/28/2017 at 03:01:26 PM by saroyanm

  • Description modified (diff)

Updated the description in order to reflect the uncommited changes INFO as well.

comment:6 Changed on 11/28/2017 at 03:04:21 PM by abpbot

A commit referencing this issue has landed:
​Issue 6103 - Use new buildtools.build interface and fixed uncommited changes warning

comment:7 Changed on 11/28/2017 at 03:05:06 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 12/11/2017 at 09:56:52 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed/done.

adblockplusui / 204:24f73c8f3eb8

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.