Opened on 12/04/2017 at 02:43:51 PM
Closed on 12/04/2017 at 04:10:12 PM
Last modified on 12/11/2017 at 10:04:12 AM
#6139 closed defect (fixed)
Update buildtools dependency to revision d9e8c5035624
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.0.2-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | tlucas, sebastian, trev | Blocked By: | #5996 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Background
We made some improvements #5996 to the release automation which would be nice to use for the upcoming 3.0.2 Firefox release. To do that we'll need to update the buildtools dependency.
Included changes in buildtools
The list of changes imported by this is:
| Ticket | Summary | Component |
|---|---|---|
| #6021 | Refactor build.py to use modern argparse | Automation |
| #5996 | Let release automation create Firefox builds | Automation |
What to change
Update the buildtools dependency to:
| mercurial | git |
| d9e8c5035624 | 0c8a9db |
Adjust calls to buildtools.build.processArgs(BASE_DIR, sys.argv) to buildtools.build.process_args(BASE_DIR).
Update the example commands in the README since the -t platform argument must now come after the command name.
Hints for testers
Since there have been a bunch of changes to the build scripts here we should verify that the produced builds haven't changed inadvertently. I'll (Dave) do that.
Attachments (0)
Change History (7)
comment:1 Changed on 12/04/2017 at 02:44:49 PM by kzar
- Component changed from Unknown to Platform
- Milestone set to Adblock-Plus-3.0.2-for-Chrome-Opera-Firefox
comment:4 Changed on 12/04/2017 at 03:19:29 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 12/04/2017 at 04:09:48 PM by abpbot
comment:6 Changed on 12/04/2017 at 04:10:12 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 12/11/2017 at 10:04:12 AM by kzar
- Verified working set
(I can't assign myself as the tester, but I have verified that the builds stayed the same with this change.)
A commit referencing this issue has landed:
Issue 6139 - Update buildtools dependency to revision d9e8c5035624