Opened on 12/20/2017 at 02:11:38 PM

Closed on 02/21/2018 at 06:29:17 PM

Last modified on 03/27/2018 at 12:52:14 PM

#6209 closed defect (fixed)

Different font is used in some translations and Filter Lists table status column missalignment

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: Shikitita, jeen, ire, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29654555/

Description (last modified by saroyanm)

Environment

Chrome V63

How to reproduce

  1. Download ​adblockplusui repository and run the test server
  2. Navigate to -> ​http://127.0.0.1:5000/desktop-options.html?locale=ru#advanced
  3. Observe

Observed behaviour

  • Font weight looks completely different from the default en_US one especially headers are noticeable (Though in FF they look different)
  • Filter List Status column text next to toggle button breaks to the next libe

Screenshot attachments: Firefox v57, Chrome v63

Expected behaviour

  • Font weight are same as in the en_US
  • Status column text fits while can, but when it breaks there shouldn't be a left margin.

Attachments (2)

FF-font-weight.png​ (106.2 KB) - added by saroyanm on 12/20/2017 at 02:13:22 PM.
chrome-font-weight.png​ (128.5 KB) - added by saroyanm on 12/20/2017 at 02:13:30 PM.

Download all attachments as: .zip

Change History (12)

Changed on 12/20/2017 at 02:13:22 PM by saroyanm

Changed on 12/20/2017 at 02:13:30 PM by saroyanm

comment:1 Changed on 12/20/2017 at 02:15:20 PM by saroyanm

  • Description modified (diff)

comment:2 Changed on 12/20/2017 at 02:21:44 PM by saroyanm

  • Summary changed from Filter list status column text next to the toggle button breaks to next line to Font weight difference in translations and Filter Lists table status column missalignment

comment:3 Changed on 12/20/2017 at 02:34:10 PM by saroyanm

  • Cc Ross added

comment:4 Changed on 01/02/2018 at 01:18:15 PM by saroyanm

  • Owner set to saroyanm

comment:5 Changed on 01/02/2018 at 03:41:54 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 01/10/2018 at 11:07:00 AM by saroyanm

  • Summary changed from Font weight difference in translations and Filter Lists table status column missalignment to Different font is used in some translations and Filter Lists table status column missalignment

comment:8 Changed on 02/21/2018 at 06:29:17 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed on 02/21/2018 at 07:02:00 PM by saroyanm

I've created a followup ticket to fix/investigate what can we do with the missing Source Sans Pro support for some languages

comment:10 Changed on 03/27/2018 at 12:52:14 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed for Russian and Vietnamese. This still occurs with Greek (opened as #6530)

ABP 3.0.2.1998
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.