Opened on 12/20/2017 at 01:54:44 PM
Closed on 12/20/2017 at 02:23:11 PM
Last modified on 03/20/2018 at 11:03:15 AM
#6208 closed defect (fixed)
Update adblockplusui dependency to revision f70786b535e3
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, saroyanm, greiner | Blocked By: | #6179, #6201 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Background
We've fixed a problem which was preventing the "Hide targeted messages?" notifications from triggering (#6201) and we've also updated lots of translations for the new options page (#6179). Now we need to update the adblockplusui dependency to make use of those changes.
Included changes in adblockplusui
The list of changes imported by this is:
| Ticket | Summary | Component |
|---|---|---|
| #6201 | "Hide targeted messages?" notification not triggering | User-Interface |
| #6199 | Acceptable Ads link broken on mobile options page | User-Interface |
| #6179 | Import existing adblockplusui translations from Crowdin | User-Interface |
| #6115 | Refactor icons | User-Interface |
What to change
Update the adblockplusui dependency to:
| mercurial | git |
| f70786b535e3 | 8103830 |
Hints for testers
- Test that the "Hide targeted messages?" notification is triggered for websites such as nexusmods.com.
- With the new options page (desktop Firefox) ensure that
- the strings are look OK, testing different languages
- the interface to add and remove filters and subscriptions works
- the buttons to toggle preferences and AA work
- the social media buttons work
- the AA with privacy conflict message works, including the button to hide it
Attachments (0)
Change History (5)
comment:2 Changed on 12/20/2017 at 02:18:45 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 12/20/2017 at 02:21:30 PM by abpbot
comment:4 Changed on 12/20/2017 at 02:23:11 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 03/20/2018 at 11:03:15 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Strings are updated and generally look okay, some languages have some minor alignment/padding issues (such as in the cog dropdowns) but functionality is fine. Privacy conflict message works as expected.
ABP 3.0.2.1983
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 49 / Windows 7
A commit referencing this issue has landed:
Issue 6208 - Update adblockplusui dependency to revision f70786b535e3