Opened on 01/15/2018 at 10:42:37 AM
Closed on 08/29/2019 at 05:43:52 PM
#6266 closed change (rejected)
[emscripten] Add tests for case lowering functionality
Reported by: | sergz | Assignee: | |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Core | Keywords: | closed-in-favor-of-gitlab |
Cc: | hfiguiere | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
Changing the case of characters can be a tricky operation, therefore we should ensure that
- it works not only for ASCII
- it does not depend on a global locale (in particular when it's compiled with Visual C++ or for android)
- the behavior of some edge cases can deviate from the standard but it should be expected (check that there are no such cases in commonly used subscriptions)
- there is no undefined behavior
What to change
Add the corresponding tests, preferably testing the same cases in JS and in native versions.
Attachments (0)
Change History (2)
comment:1 Changed on 01/15/2018 at 10:44:32 AM by sergz
- Summary changed from Add tests for case lowering functionality to [emscripten] Add tests for case lowering functionality
comment:2 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.