Opened on 01/15/2018 at 10:49:07 AM

Closed on 08/29/2019 at 05:43:52 PM

#6267 closed change (rejected)

[emscripten] Get rid of global storage of regular expressions in native implementation

Reported by: sergz Assignee:
Priority: P3 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

It's a continuation from ​https://codereview.adblockplus.org/29661608/diff/29663576/compiled/library.cpp#newcode45.

What to change

Introduce an opaque structure representing a regular expression (e.g. by typedefs switched on by #ifdef conditions), which is just and integer in the case of JS and std::wregex in the case of C++, therefore the methods working with it should be adjusted and global regexPool and regexPoolMutex should be removed.

Attachments (0)

Change History (1)

comment:1 Changed on 08/29/2019 at 05:43:52 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the ​new issue tracker.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.