Opened on 01/15/2018 at 01:50:57 PM
Closed on 05/23/2018 at 11:04:26 PM
Last modified on 05/23/2018 at 11:05:13 PM
#6271 closed change (duplicate)
remove getFilterByKey and the things around it from elemHide.js
Reported by: | sergz | Assignee: | |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Core | Keywords: | |
Cc: | hfiguiere, kzar, greiner, jsonesen | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
Reminded by #5142 that we don't need filter keys, although it's not a big deal, it can still save some memory and precious CPU cycles (see #hub:6968).
What to change
See the title.
Attachments (0)
Change History (6)
comment:1 Changed on 05/22/2018 at 07:02:17 PM by jsonesen
- Owner set to jsonesen
comment:2 Changed on 05/23/2018 at 12:44:50 AM by jsonesen
comment:3 Changed on 05/23/2018 at 12:45:04 AM by jsonesen
- Owner jsonesen deleted
comment:4 Changed on 05/23/2018 at 02:38:57 PM by kzar
- Cc jsonesen added
Well in that case Jon please could you reject this issue as a Duplicate and leave a comment linking to the other issue?
comment:5 Changed on 05/23/2018 at 11:04:26 PM by jsonesen
- Resolution set to duplicate
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Actually looks like this has been done: https://github.com/adblockplus/adblockpluscore/commit/30cf480583cbd3c497efdfd589fc4d09c1bad54a#diff-9bc60be24d2ee51263e2c3ef854244df