Opened on 01/16/2018 at 04:28:24 PM
Closed on 02/12/2018 at 04:56:23 PM
#6280 closed change (fixed)
[emscripten] Map::begin should be consistent with HashContainerIterator::operator++
| Reported by: | sergz | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | hfiguiere | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Map::begin returns just a first entry of the internal array but HashContainerIterator::operator++ skips invalid entries.
What to change
Map::begin should also skip invalid entries.
Add tests.
Attachments (0)
Change History (8)
comment:1 Changed on 01/23/2018 at 09:45:05 PM by hfiguiere
comment:2 Changed on 01/23/2018 at 09:56:02 PM by hfiguiere
Filtering out deleted entries, that's issue #6281
Last edited on 01/23/2018 at 09:56:12 PM
by hfiguiere
comment:3 Changed on 02/09/2018 at 01:50:33 AM by hfiguiere
- Resolution set to worksforme
- Status changed from new to closed
According to this:
https://hg.adblockplus.org/adblockpluscore/file/6f6a49dfae27/compiled/Map.h#l47
If we are not at the end and the current is invalid() we call operator++
It's already in there. Closing as WORKSFORME.
comment:4 Changed on 02/09/2018 at 01:59:28 AM by hfiguiere
- Resolution worksforme deleted
- Status changed from closed to reopened
comment:5 Changed on 02/09/2018 at 01:59:54 AM by hfiguiere
- Owner set to hfiguiere
comment:6 Changed on 02/09/2018 at 02:01:20 AM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
Adding tests.
comment:7 Changed on 02/12/2018 at 04:54:49 PM by abpbot
A commit referencing this issue has landed:
Issue 6280 - Check that we don't return invalid entries
comment:8 Changed on 02/12/2018 at 04:56:23 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
It ignore the invalid entries, but not the deleted entries.
HashContainerIterator() calls operator++ if the current entry is invalid.
I think we should also filter out deleted entries.