Opened on 01/16/2018 at 04:28:56 PM
Closed on 02/13/2018 at 03:49:55 PM
#6281 closed change (fixed)
[emscripten] Map iterator interface should exclude deleted and invalid entries
| Reported by: | sergz | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | hfiguiere | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by hfiguiere)
Background
The iterator should also skip deleted entries like it does for invalid entries.
What to change
Map class, https://codereview.adblockplus.org/29587914/diff/29631257/compiled/ElemHide.cpp#newcode217 and check other places.
Add tests.
Attachments (0)
Change History (4)
comment:1 Changed on 02/09/2018 at 01:51:55 AM by hfiguiere
- Description modified (diff)
- Owner set to hfiguiere
comment:2 Changed on 02/12/2018 at 11:53:40 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 02/13/2018 at 03:49:08 PM by abpbot
comment:4 Changed on 02/13/2018 at 03:49:55 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6281 - Don't return deleted entries