Opened on 01/18/2018 at 08:43:03 AM

Closed on 01/19/2018 at 11:36:41 AM

#6286 closed change (fixed)

Remove common scripts duplicating

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: sergz, diegocarloslima Blocked By: #6264
Blocking: #6273 Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29674558/

Description

Background

We're having few duplicates of the scripts (delete_dir.py, subproc.py) used both in libadblockplus and libadblockplus-android. It makes maintaining more difficult and should be avoided.

What to change

Move duplicated files to some "common" path

Attachments (0)

Change History (4)

comment:1 Changed on 01/18/2018 at 08:44:39 AM by asmirnov

  • Blocked By 6264 added

comment:2 Changed on 01/18/2018 at 08:47:58 AM by asmirnov

  • Blocking 6273 added

comment:3 Changed on 01/19/2018 at 08:04:35 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 01/19/2018 at 11:36:41 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.