Opened on 01/18/2018 at 11:03:53 AM
Last modified on 10/08/2019 at 06:03:56 PM
#6287 reviewing change
Create codename Orca v.0 to launch internally to the team
| Reported by: | tpregueiro | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | jwangenheim, diegocarloslima, asmirnov, mvelchevski, mario, greiner | Blocked By: | #6273 |
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by jwangenheim)
Background
We already have a working version of adblockplus working on top of chromium for Android. We would like to start distributing a version of it to the team internally, to get their first impressions.
What to change
- Create a build with existing code (chromium+ABP)
- Change the icon
- Change the name of the App to Orca
- Change the namespace to avoid conflict with other chromium based browsers people may have on their phones
- Add a basic versioning
Attachments (4)
Change History (24)
Changed on 01/18/2018 at 11:26:09 AM by martin
comment:1 Changed on 01/18/2018 at 11:27:00 AM by martin
I updated this ticket with all assets needed to begin working on the project. Let me know if anything is missing or broken.
comment:2 Changed on 01/18/2018 at 11:32:54 AM by tpregueiro
- Cc jwangenheim diegocarloslima asmirnov mvelchevski mario added
comment:3 Changed on 01/18/2018 at 11:37:05 AM by mario
We'll also need a ticket to create a repository. @Jens, Diego, Anton, would you like to work with Mercurial or GitLab?
comment:4 Changed on 01/24/2018 at 11:11:31 AM by jwangenheim
Gitlab is fine for me
comment:5 Changed on 01/24/2018 at 01:47:00 PM by diegocarloslima
Gitlab is fine for me too
comment:6 Changed on 01/25/2018 at 07:44:42 AM by asmirnov
Gitlab for sure
comment:7 Changed on 01/25/2018 at 09:32:05 AM by mario
An internal issue for creating the Repo has been created: #7382 on Hub.
You should get invitations soon.
comment:8 Changed on 01/26/2018 at 01:48:11 PM by jwangenheim
Should we add a distribution tool in a separate ticket (HockeyApp or something similar)?
comment:9 Changed on 01/29/2018 at 10:02:26 AM by asmirnov
- Blocked By 6273 added
comment:10 Changed on 01/29/2018 at 10:16:02 AM by asmirnov
comment:11 Changed on 01/30/2018 at 06:20:11 AM by asmirnov
@martin, new icon sizes required.
See icon dimensions in https://gitlab.com/adblockplus/chromium/tree/master/chrome/android/java/res_chromium/drawable- ...
Also it would be great to have 'product_logo_name' files: https://gitlab.com/adblockplus/chromium/blob/master/chrome/android/java/res_chromium/drawable-hdpi/product_logo_name.png
(see other dirs) too.
Could you prepare other files to be overriden, e.g https://gitlab.com/adblockplus/chromium/tree/master/chrome/android/java/res_chromium/mipmap-hdpi/app_shortcut_icon.png and app_single_page_icon.png.
BTW please check you have transparency in .png (it seems it's just white background instead at the moment).
comment:12 Changed on 01/30/2018 at 08:41:15 AM by tpregueiro
- Description modified (diff)
For the time being, and after discussion with the team we agreed to ditch the requirement to add a splash screen. Updating the ticket description
comment:13 Changed on 01/30/2018 at 08:45:33 AM by asmirnov
We could use FirstRunActivity for onboarding: https://gitlab.com/adblockplus/chromium/blob/abp/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
Changed on 01/30/2018 at 12:17:14 PM by martin
comment:14 Changed on 01/30/2018 at 12:17:54 PM by martin
@asmirnov I included a new archive containing the missing assets. Let me know if anything needs fixing.
comment:15 Changed on 01/30/2018 at 12:33:58 PM by asmirnov
I believe we should not just hardcode "Orca" string to the files, but update them while building.
See https://github.com/Jubata/Cheetah-browser/wiki
Changed on 01/30/2018 at 01:36:28 PM by jwangenheim
Fixed shortcut icons
Changed on 01/30/2018 at 01:47:55 PM by jwangenheim
One more time, fixed shortcut icons
comment:16 Changed on 01/31/2018 at 07:38:19 AM by jwangenheim
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:17 Changed on 01/31/2018 at 07:38:34 AM by jwangenheim
- Owner set to jwangenheim
comment:18 Changed on 02/01/2018 at 08:35:01 AM by jwangenheim
- Description modified (diff)
comment:19 Changed on 02/01/2018 at 03:43:28 PM by greiner
- Cc greiner added
comment:20 Changed on 09/25/2019 at 06:17:46 AM by impulsepp
spam
Archive containing assets needed to kickstart the development process