Opened on 01/24/2018 at 03:44:13 PM
Closed on 03/07/2018 at 01:59:26 PM
Last modified on 04/05/2018 at 10:32:05 AM
#6309 closed change (fixed)
Start using SASS in adblockplusui
| Reported by: | saroyanm | Assignee: | agiammarchi |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner, saroyanm | Blocked By: | |
| Blocking: | #6117 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by agiammarchi)
Background
In order to organize CSS styles we would like to introduce SASS in adblockplusui, we decided to use SASS (rather than other tools), because websites team is also making use of SASS and that will help to easily adapt the websites-default.
What problem is this solving
SASS gives us the following opportunities:
- we can use @import "module.scss"; to bundle modules together with the output
- we can use $variable: value; to avoid issues with Edge 15
We might discuss the benefit of using any non standard SASS feature too, but for the time being we'll try to modularize CSS without bringing in non standard syntax (except for imports and/or variables, where appropriate).
What to change
Start using SASS.
[We still need to agree on task watcher/runner]
Attachments (0)
Change History (9)
comment:1 Changed on 01/24/2018 at 04:07:27 PM by saroyanm
- Blocking 6117 added
comment:2 Changed on 01/26/2018 at 01:57:21 PM by greiner
- Cc greiner added
comment:3 Changed on 03/01/2018 at 02:35:27 PM by agiammarchi
- Owner set to agiammarchi
- Review URL(s) modified (diff)
comment:4 Changed on 03/01/2018 at 02:36:07 PM by agiammarchi
- Cc saroyanm added
comment:5 Changed on 03/01/2018 at 02:36:29 PM by agiammarchi
- Ready set
comment:7 Changed on 03/07/2018 at 01:56:23 PM by abpbot
comment:8 Changed on 03/07/2018 at 01:59:26 PM by agiammarchi
- Resolution set to fixed
- Status changed from new to closed
comment:9 Changed on 04/05/2018 at 10:32:05 AM by Ross
Just noting: This has been started and does not look to have had any adverse effects on the builds.
A commit referencing this issue has landed:
Issue 6309 - Start using SASS in adblockplusui