Opened on 01/27/2018 at 05:36:32 PM

Closed on 01/29/2018 at 12:23:39 PM

Last modified on 02/08/2018 at 12:39:40 PM

#6332 closed defect (fixed)

[ABP dev 3.0.2.1963] TypeError: Cannot read property 'sheet' of undefined

Reported by: Lain_13 Assignee: kzar
Priority: P1 Milestone: Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: mjethani, kzar, mapx, Ross, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29683555/

Description (last modified by kzar)

Environment

Google Chrome 63.0.3239.132
Adblock Plus development build 3.0.2.1963

How to reproduce

  1. Add any list of filters with hiding filters. EasyList is enough.
  2. Refresh any page, even this one.

Observed behaviour

Error in event handler for (unknown): TypeError: Cannot read property 'sheet' of undefined
    at ElemHide.addSelectorsInline (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.preload.js:619:18)
    at browser.runtime.sendMessage.response (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.preload.js:681:14)

Expected behaviour

No errors related to ABP in the console, hiding works as intended.

Notes

Attachments (0)

Change History (9)

comment:1 Changed on 01/28/2018 at 08:06:39 AM by mapx

  • Cc mjethani kzar mapx added

comment:2 Changed on 01/29/2018 at 10:21:59 AM by kzar

  • Cc Ross sebastian added
  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

comment:3 Changed on 01/29/2018 at 10:23:06 AM by kzar

  • Owner set to kzar

comment:4 Changed on 01/29/2018 at 10:29:24 AM by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 01/29/2018 at 12:21:51 PM by abpbot

A commit referencing this issue has landed:
Issue 6332 - Fix typo in recent inline style changes

comment:6 Changed on 01/29/2018 at 12:23:39 PM by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 follow-up: Changed on 01/29/2018 at 05:07:52 PM by Lain_13

Looks fine in 3.0.2.1964

comment:8 in reply to: ↑ 7 Changed on 01/29/2018 at 06:04:56 PM by kzar

Replying to Lain_13:

Looks fine in 3.0.2.1964

Great, thanks for confirming.

comment:9 Changed on 02/08/2018 at 12:39:40 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed.

ABP 3.0.2.1968
Chrome 64 / 49 / Canary (66) / Windows 7
Opera 49 / 36 / Beta (52) / Windows 7
Firefox 58 / 51 / Beta (59) / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.