Opened on 02/15/2018 at 07:49:34 PM

Closed on 03/15/2018 at 01:11:23 PM

Last modified on 03/15/2018 at 01:11:48 PM

#6394 closed defect (duplicate)

Favicon: Remove external dependencies from tests

Reported by: ashephard Assignee: ashephard
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Tests shouldn't include any external dependencies. These will be replaced by mock objects.

Attachments (0)

Change History (2)

comment:1 Changed on 03/15/2018 at 01:11:23 PM by ashephard

  • Resolution set to duplicate
  • Status changed from new to closed

comment:2 Changed on 03/15/2018 at 01:11:48 PM by ashephard

Closed this as the ticket now resides on the GitLab platform. Found here: ​https://gitlab.com/eyeo/adblockplus/FavIcon/issues/1

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ashephard.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.