Opened on 02/15/2018 at 07:53:32 PM

Closed on 03/12/2018 at 10:29:02 AM

#6395 closed defect (fixed)

Favicon: Ignore fetched icons which aren't square.

Reported by: ashephard Assignee: ashephard
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Currently, the Favicon library fetches icons which aren't square. These icons should be ignored.

Attachments (0)

Change History (3)

comment:1 Changed on 02/28/2018 at 02:06:47 PM by ashephard

References to og:image objects on Facebook & Twitter have been removed from the Favicon library which should aid this issue.
More testing needs to be performed in order to confirm that this have been resolved however.

comment:2 Changed on 03/12/2018 at 10:28:52 AM by ashephard

Closing ticket due to the fix being included as part of Issue #6244 code review and subsequent commit.

comment:3 Changed on 03/12/2018 at 10:29:02 AM by ashephard

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ashephard.
 
Note: See TracTickets for help on using tickets.