Opened on 02/26/2018 at 09:49:33 AM
Closed on 02/26/2018 at 04:40:09 PM
#6419 closed defect (fixed)
Duplicated text on adblockplus.org/contribute
| Reported by: | greiner | Assignee: | juliandoucette |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | juliandoucette, lisabielik | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Environment
N/A
How to reproduce
Observed behaviour
First paragraph is repeated in third paragraph.
Expected behaviour
No text should be duplicated.
Further information
Presumably, the third paragraph was meant as a replacement for the two preceding ones because the second paragraph still mentions that people can suggest filters on our forum which is no longer accurate (see also #4934).
See also https://adblockplus.org/forum/viewtopic.php?f=9&t=55168
Attachments (0)
Change History (8)
comment:2 Changed on 02/26/2018 at 11:22:04 AM by mapx
- Summary changed from Duplicted text on adblockplus.org/contribute to Duplicated text on adblockplus.org/contribute
comment:3 Changed on 02/26/2018 at 03:34:38 PM by juliandoucette
- Owner set to juliandoucette
comment:4 follow-up: ↓ 6 Changed on 02/26/2018 at 03:47:33 PM by juliandoucette
The third paragraph wasn't supposed to be a new paragraph at all. It was supposed to be *just* a new link in the first paragraph.
I haven't found any indication that the second paragraph should be removed. If you will confirm that it is no longer accurate then I will remove it separately.
comment:5 Changed on 02/26/2018 at 03:54:48 PM by abpbot
A commit referencing this issue has landed:
Issue 6419 - Removed duplicate text on contribute page caused by #4934
comment:6 in reply to: ↑ 4 Changed on 02/26/2018 at 03:59:33 PM by greiner
Sorry, I meant to write "fourth paragraph" but seems you know which one I was referring to regardless. I've updated the ticket description nevertheless.
Replying to juliandoucette:
I haven't found any indication that the second paragraph should be removed. If you will confirm that it is no longer accurate then I will remove it separately.
I can confirm that. The subforum it links to is locked and filter-related topics need to be discussed on the respective filter list author's sites.
comment:7 Changed on 02/26/2018 at 04:35:38 PM by abpbot
A commit referencing this issue has landed:
Issue 6419 - Removed instruction to visit our forum to suggest filters
comment:8 Changed on 02/26/2018 at 04:40:09 PM by juliandoucette
- Resolution set to fixed
- Status changed from new to closed
Thanks greiner. Please follow https://gitlab.com/eyeo/web.adblockplus.org/issues/24 for future updates.
on it.