Opened on 02/26/2018 at 05:56:11 PM
Last modified on 09/17/2018 at 12:35:08 PM
#6425 new change
[meta] Further modernise our JavaScript coding style rules, ESLint config and code bases
Reported by: | kzar | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Unknown | Keywords: | |
Cc: | mjethani, agiammarchi, sergz, sebastian, hfiguiere, fhd, greiner | Blocked By: | #6411, #6424, #6433, #6434, #6445, #6447, #6449, #6482, #6559, #6564, #6581, #6737, #6959 |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by kzar)
Background
A while back we had a push to use more modern JavaScript features, improve our coding style rules and begin using ESLint (#3692). There's still more work to do however as Manish pointed out.
So for the second push I thought I'd create this meta-issue so that we can keep track of the suggestions of how we can improve things as we work through them.
We'll need to check proposed features are supported by the browsers we support (e.g. Chrome 49, Firefox 51, Edge 40 10.0.15063 Creators update, etc), that their use will improve the code base and that we're all agreed about that. Also we'll need to keep our JavaScript coding style rules and ESLint configuration in sync with what we all agree. (Then of course we'll need to update our codebases as well!) In other words this is quite a bit of work in practice, but I think worthwhile.
Ticket | Status | Resolution | Summary | Component | Owner |
---|---|---|---|---|---|
#6411 | closed | rejected | Allow sparse arrays in eslint-config-eyeo | Automation | |
#6424 | closed | rejected | Replace underscore properties with symbols | Platform | |
#6433 | closed | rejected | Use generators to return lists of things | Platform | |
#6434 | closed | rejected | Define helpers for non-array iterables | Core | |
#6445 | new | [meta] Make use of default function parameters | Unknown | ||
#6447 | closed | rejected | Switch to Harmony modules | Core | |
#6449 | closed | rejected | Switch to Harmony modules in adblockpluschrome | Platform | |
#6482 | new | [meta] Use the class keyword in JavaScript code | Unknown | ||
#6564 | closed | rejected | Replace desc and extend in lib/coreUtils.js with __proto__ | Core | |
#6581 | closed | worksforme | [meta] Clarify the rules for using const vs let in JavaScript code | Unknown | |
#6737 | closed | fixed | Use String.includes instead of String.indexOf where the index is not needed | Core | mjethani |
#6959 | closed | rejected | Switch to using async/await in core unit tests | Core |
Attachments (0)
Change History (18)
comment:2 Changed on 02/26/2018 at 05:56:47 PM by kzar
- Blocking 6411, 6424 removed
comment:3 Changed on 02/26/2018 at 05:57:06 PM by kzar
- Blocked By 6411, 6424 added
comment:4 Changed on 02/26/2018 at 05:58:14 PM by kzar
- Blocked By
comment:6 Changed on 02/28/2018 at 08:11:09 PM by mjethani
- Blocked By 6433 added
comment:7 Changed on 03/01/2018 at 10:59:01 AM by mjethani
- Blocked By 6434 added
comment:8 Changed on 03/05/2018 at 07:55:10 PM by mjethani
- Blocked By 6445 added
comment:9 Changed on 03/06/2018 at 07:26:03 AM by mjethani
- Blocked By 6447 added
comment:10 Changed on 03/06/2018 at 10:18:05 AM by mjethani
- Blocked By 6449 added
comment:11 Changed on 03/07/2018 at 11:11:59 AM by kzar
- Description modified (diff)
comment:12 Changed on 03/15/2018 at 07:06:00 AM by mjethani
- Blocked By 6482 added
comment:13 Changed on 04/06/2018 at 05:30:04 AM by mjethani
- Blocked By 6559 added
comment:14 Changed on 04/08/2018 at 08:53:15 AM by mjethani
- Blocked By 6564 added
comment:15 Changed on 04/12/2018 at 04:54:13 PM by agiammarchi
- Blocking 6581 added
comment:16 Changed on 04/14/2018 at 02:35:43 PM by mjethani
- Blocked By 6581 added
- Blocking 6581 removed
comment:17 Changed on 06/07/2018 at 09:50:31 AM by mjethani
- Blocked By 6737 added
comment:18 Changed on 09/17/2018 at 12:35:08 PM by mjethani
- Blocked By 6959 added