Opened on 09/17/2018 at 12:35:08 PM
Closed on 08/29/2019 at 05:43:52 PM
#6959 closed change (rejected)
Switch to using async/await in core unit tests
| Reported by: | mjethani | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | erikvold | Blocked By: | |
| Blocking: | #6425 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29984555/ |
||
Description
Background
Async functions have been available at least since Node.js 8.x and we should start using them in our unit tests.
What to change
[TBD]
Attachments (0)
Change History (12)
comment:1 Changed on 11/15/2018 at 04:38:34 AM by erikvold
- Cc erikvold added
comment:5 Changed on 01/17/2019 at 06:08:44 PM by hfiguiere
- Status changed from new to reviewing
comment:6 Changed on 01/18/2019 at 01:24:59 AM by abpbot
A commit referencing this issue has landed:
Issue 6959 - Use async/await in test/stub-modules/io.js
comment:7 Changed on 01/18/2019 at 01:32:32 AM by abpbot
A commit referencing this issue has landed:
Issue 6959 - Use async/await in test/filterStorage_readwrite.js
comment:8 Changed on 01/18/2019 at 01:35:06 AM by abpbot
A commit referencing this issue has landed:
Issue 6959 - Use async/await in test/browser/elemHideEmulation.js
comment:9 Changed on 02/07/2019 at 03:23:39 AM by abpbot
Some commits referencing this issue have landed:
comment:10 Changed on 03/17/2019 at 08:10:36 AM by mjethani
- Review URL(s) modified (diff)
comment:11 Changed on 03/19/2019 at 03:56:28 PM by abpbot
A commit referencing this issue has landed:
Issue 6959 - Use async/await in test/_common.js
comment:12 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from reviewing to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Probably worth doing when we convert from nodeunit to something else in Issue #6820.