Opened on 03/15/2018 at 11:01:09 AM
Closed on 03/19/2018 at 01:33:36 PM
#6485 closed change (rejected)
Update libadblockplus dependency to revision hg:c1d8984aa1d4
Reported by: | asmirnov | Assignee: | |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Libadblockplus-Android | Keywords: | |
Cc: | sergz | Blocked By: | |
Blocking: | #6466 | Platform: | Android |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
Some significant changes were done in libadblockplus(https://hg.adblockplus.org/libadblockplus/rev/c1d8984aa1d4) so we need to update libadblockplus-android to use it.
What to change
Recompile libadblockplus-android and update dependencies file.
Modify source code if needed.
Attachments (0)
Change History (7)
comment:1 Changed on 03/15/2018 at 11:02:08 AM by asmirnov
- Cc sergz added
comment:2 Changed on 03/15/2018 at 11:08:33 AM by asmirnov
- Blocking 6466 added
comment:3 Changed on 03/16/2018 at 06:59:12 AM by abpbot
comment:4 Changed on 03/16/2018 at 07:32:46 AM by asmirnov
If updating just dependencies file to the latest -binaries, i'm having native crash (not stripped):
03-16 12:30:35.915 300-300 I/DEBUG: Abort message: '/Volumes/Android/buildbot/src/android/ndk-r12-release/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/src/abort_message.cpp:74: void abort_message(const char *, ...): assertion "terminating with uncaught exception of type std::__ndk1::bad_function_call: std::exception" failed' 03-16 12:30:35.915 300-300 I/DEBUG: r0 00000000 r1 0000159b r2 00000006 r3 00000000 03-16 12:30:35.915 300-300 I/DEBUG: r4 9f2f3db8 r5 00000006 r6 00000016 r7 0000010c 03-16 12:30:35.915 300-300 I/DEBUG: r8 9e2e4469 r9 afab831c sl 9f2f324c fp afab8130 03-16 12:30:35.915 300-300 I/DEBUG: ip 0000159b sp 9f2f2c00 lr b6f5efd5 pc b6f824b0 cpsr 60010010 03-16 12:30:35.915 300-300 I/DEBUG: backtrace: 03-16 12:30:35.915 300-300 I/DEBUG: #00 pc 000374b0 /system/lib/libc.so (tgkill+12) 03-16 12:30:35.915 300-300 I/DEBUG: #01 pc 00013fd1 /system/lib/libc.so (pthread_kill+52) 03-16 12:30:35.915 300-300 I/DEBUG: #02 pc 00014bef /system/lib/libc.so (raise+10) 03-16 12:30:35.915 300-300 I/DEBUG: #03 pc 00011531 /system/lib/libc.so (__libc_android_abort+36) 03-16 12:30:35.915 300-300 I/DEBUG: #04 pc 0000fcbc /system/lib/libc.so (abort+4) 03-16 12:30:35.915 300-300 I/DEBUG: #05 pc 00012701 /system/lib/libc.so (__libc_fatal+16) 03-16 12:30:35.915 300-300 I/DEBUG: #06 pc 000115b5 /system/lib/libc.so (__assert2+20) 03-16 12:30:35.915 300-300 I/DEBUG: #07 pc 00a21815 /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so (abort_message+76) 03-16 12:30:35.915 300-300 I/DEBUG: #08 pc 00a218d9 /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so (default_terminate_handler()+176) 03-16 12:30:35.915 300-300 I/DEBUG: #09 pc 00a20181 /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so (std::__terminate(void (*)())+4) 03-16 12:30:35.915 300-300 I/DEBUG: #10 pc 00a1fb09 /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so (__cxa_throw+96) 03-16 12:30:35.915 300-300 I/DEBUG: #11 pc 00310be1 /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so (_ZNKSt6__ndk18functionIFvRKNS0_IFvvEEEEEclES4_.isra.100+32) 03-16 12:30:35.915 300-300 I/DEBUG: #12 pc 003111df /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so (AdblockPlus::DefaultFileSystem::Read(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&, std::__ndk1::function<void (std::__ndk1::vector<unsigned char, std::__ndk1::allocator<unsigned char> >&&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&)> const&) const+114) 03-16 12:30:35.915 300-300 I/DEBUG: #13 pc 00315d4d /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so (std::__ndk1::__function::__func<(anonymous namespace)::ReadCallback(v8::FunctionCallbackInfo<v8::Value> const&)::{lambda(AdblockPlus::IFileSystem&)#1}, std::__ndk1::allocator<{lambda(AdblockPlus::IFileSystem&)#1}>, void (AdblockPlus::IFileSystem&)>::operator()(AdblockPlus::IFileSystem&)+88) 03-16 12:30:35.915 300-300 I/DEBUG: #14 pc 0030e629 /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so ((anonymous namespace)::DefaultPlatform::WithFileSystem(std::__ndk1::function<void (AdblockPlus::IFileSystem&)> const&)+20) 03-16 12:30:35.915 300-300 I/DEBUG: #15 pc 00316aa9 /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so ((anonymous namespace)::ReadCallback(v8::FunctionCallbackInfo<v8::Value> const&)+292) 03-16 12:30:35.915 300-300 I/DEBUG: #16 pc 00759958 /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so (v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))+208) 03-16 12:30:35.915 300-300 I/DEBUG: #17 pc 0078e67c /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so (v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments)+316) 03-16 12:30:35.915 300-300 I/DEBUG: #18 pc 0078eb0c /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so (v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*)+240) 03-16 12:30:35.915 300-300 I/DEBUG: #19 pc 0078ee10 /data/app/org.adblockplus.libadblockplus.android.webviewapp-1/lib/arm/libadblockplus-jni.so (v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)+44) 03-16 12:30:35.915 300-300 I/DEBUG: #20 pc 00000558 <unknown>
Libadblockplus-android sources probably have to be updated too.
basePath passed to Platform ctor is /data/data/org.adblockplus.libadblockplus.android.webviewapp/app_adblock, exists
comment:5 Changed on 03/19/2018 at 01:32:21 PM by asmirnov
- Blocking 6466 removed
comment:6 Changed on 03/19/2018 at 01:32:48 PM by asmirnov
- Blocking 6466 added
comment:7 Changed on 03/19/2018 at 01:33:36 PM by asmirnov
- Resolution set to rejected
- Status changed from new to closed
The task is deprecated because of 6500
A commit referencing this issue has landed:
Issue 6485 - Update libadblockplus dependency to revision hg:c1d8984aa1d4