Opened on 03/15/2018 at 01:15:14 PM
Closed on 03/26/2018 at 10:29:05 AM
#6486 closed change (fixed)
ABP: Move dependency references to GitLab repos.
| Reported by: | ashephard | Assignee: | ashephard |
|---|---|---|---|
| Priority: | P5 | Milestone: | Adblock-Plus-for-iOS-next |
| Module: | Adblock-Plus-for-iOS/macOS | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | iOS | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Now that GitLab will become the primary place to host our code, we should change the Carthage dependency references to reflect the change from Github to Gitlab.
What to change
Edit the Cartfile within ABP iOS for Favicon & YAJL frameworks. Said frameworks are now hosted on Gitlab and so the Cartfile references need to be updated to reflect this.
Attachments (0)
Change History (2)
Note: See
TracTickets for help on using
tickets.
Gitlab doesn't appear to support binary releases for Carthage at the moment.
This is a great convenience when it comes to installing the dependencies as a separate build is not required.
For this reason, using Github with Carthage may be a better solution with regard to hosting dependencies until there is similar support with Gitlab.
Development of the dependencies can still take place on Gitlab, if desired, while hosting them on Github.