Opened on 06/06/2014 at 01:55:29 PM
Closed on 06/06/2014 at 02:18:24 PM
Last modified on 08/26/2014 at 11:43:31 AM
#649 closed defect (fixed)
Some websites are broken on Safari due to dispatching "error" event synchronusly
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8.4-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Safari | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sebastian)
Environment
Safari 7
Filter lists: EasyList and EasyPrivacy
How to reproduce
Go to http://www.lynda.com/
Observed behaviour
The website is rendered empty. That is because the website hides its content, while loading Visual Website Optimizer (a script blocked by EasyPrivacy). There even is a fallback to make sure that the website is shown again if this external script fails to load. But that code expects the error event to be dispatched asynchronously. However we dispatch it directly from inside the beforeload event, which is triggered synchronously as soon as a resource is created.
Expected behaviour
The website should be shown also when the Visual Website Optimizer script is blocked by EasyPrivacy.
Attachments (0)
Change History (5)
comment:1 Changed on 06/06/2014 at 01:59:36 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 06/06/2014 at 02:18:24 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 08/26/2014 at 11:43:31 AM by sebastian
- Platform changed from Unknown to Safari
https://hg.adblockplus.org/adblockpluschrome/rev/f5eee8a125c2