Opened on 03/20/2018 at 01:06:36 AM
Closed on 03/20/2018 at 10:22:41 AM
Last modified on 05/14/2018 at 09:04:16 AM
#6503 closed defect (fixed)
Fix builds on Windows
| Reported by: | oleksandr | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | tlucas, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
In #6021 we have refactored the build.py script. Unfortunately it broke all builds on Windows, since it assumes Windows style line endings (\r\n) in docstring (__doc__), when in reality there are only '\n' symbols.
Environment
Windows 10, FCU. Python 2.7.13
How to reproduce
- Initiate any build process. For example build.py build -t edge or build.py devenv -t chrome.
Observed behaviour
Build fails with an error.
Expected behaviour
Build should succeed.
Attachments (0)
Change History (7)
comment:1 Changed on 03/20/2018 at 01:10:48 AM by oleksandr
- Ready set
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/20/2018 at 01:19:35 AM by sebastian
- Priority changed from Unknown to P2
comment:3 Changed on 03/20/2018 at 10:03:20 AM by abpbot
comment:4 Changed on 03/20/2018 at 10:22:41 AM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 05/10/2018 at 02:03:37 PM by Ross
I haven't been able to test this as ensure_dependancies.py eventually fails because it attempts to run bash at some point (for linting I think). Should I just be able to build using the normal windows command line or should I be using Cygwin/Subsystem for Windows/Other?
comment:6 Changed on 05/10/2018 at 02:11:16 PM by sebastian
As far as I'm concerned, you can skip testing this part. Whether building the extension succeeds is irrelevant for users, and for the upcoming release. Generally, when testing buildtools changes, its mostly relevant that they don't have any (unexpected) effect on the generated builds.
comment:7 Changed on 05/14/2018 at 09:04:16 AM by Ross
Just to note: I still could not build on plain Windows. However building inside Linux Subsystem for Windows 10 works fine.
A commit referencing this issue has landed:
Issue 6503 - Fix builds on Windows