Actions inside popup ui notifications do not properly remove notification

[Ross]

Environment

ABP 3.0.2.1983
Chrome 49 / 65 / Windows 7
Opera 49 / Windows 7

How to reproduce

1. Save the notification below into a directory.
2. Serve it python -m SimpleHTTPServer
3. Install ABP.
4. [ABP Icon] > [Right Click Popup] > [Inspect].
5. In the popup console, set the notification url: browser.runtime.sendMessage({type: "prefs.set", key: "notificationurl", value: "<serveurl>"})
6. Wait for ABP to request notifications.
7. Open the popup UI to see notification.
8. Select the [X] and [Close this notification].
9. Open popup UI again.

10. Select the [X] and [Stop showing notifications]

Test data

{
  "notifications": [
    {
      "id": "1",
      "message": {
        "en-US": "This is a information notification."
      },
      "severity": "information",
      "title": {
        "en-US": "Test Normal Notification"
      }
    }
  ],
  "version": "201707281538"
}

Observed behaviour

The [Close this notification] action closes the notification. But the notification reappears again when the popup ui is reopened.

The [Stop showing notifications] action seems to unset the [Show useful notifications] option in [Advanced]. But does not remove the notification from the popup ui as with [Close this notification] above.

Expected behaviour

In the 3.0.2 release, selecting [Close this notification] removes the notification from the UI and it is not present when the popup ui is reopened. The same with [Stop showing notifications].

What to change

• Update the adblockplusui dependency to hg:9546f62e182f git:7411639 which will include the fixes for #6511 and #6510.
• Send a "notifications.clicked" message instead of calling notification.onClicked() from the popup code.
• Implement notificationHelpre.notificationClicked.

Notes

• This regression was caused by ​Issue 5593 - Use messaging for the popup's notification code.
• ​Seems like this line is the problem. We'll need to send a message back instead of attempting to call notification.onClicked().
• This fix will update the adblockplusui dependency, pulling in #6510 and #6512.

Hints for testers

• Test that #6511 and #6510 are fixed.
• No other changes are included, so nothing else should need to be tested.

[kzar]

I can reproduce this, investigating now.

[kzar]

Despite the problematic commit landing in October 2017 this is a regression since the last Chrome release. Putting it back to P1.

[abpbot]

A commit referencing this issue has landed:
​Issue 6511 - Use messaging to register popup notification clicks

[Ross]

Fixed.

ABP 3.0.2.1998
Chrome 49 / 65 / Windows 7