Opened on 03/22/2018 at 02:39:18 PM
Closed on 03/22/2018 at 04:54:28 PM
Last modified on 03/23/2018 at 03:41:04 PM
#6512 closed change (fixed)
Add notifications.clicked message listener
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner, sebastian | Blocked By: | |
| Blocking: | #6511 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Background
With #5593 we began using messaging in the popup's notification code, unfortunately we forgot about the notification's onClick() method, which caused the symptoms documented in #6511.
What to change
Add the "notifications.clicked" message handler. It should call the notificationHelper.notificationClicked() function with no arguments.
Integration notes
Add the notificationHelper.notificationClicked() function (see #6511).
Attachments (0)
Change History (7)
comment:1 Changed on 03/22/2018 at 02:39:33 PM by kzar
- Blocking 6511 added
comment:2 Changed on 03/22/2018 at 02:43:53 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 03/22/2018 at 04:53:13 PM by abpbot
comment:4 Changed on 03/22/2018 at 04:54:28 PM by kzar
- Priority changed from Unknown to P1
- Ready set
- Resolution set to fixed
- Status changed from reviewing to closed
(Marking this as P1 since it blocks a P1 issue, marking it as Ready since it already passed review and landed.)
comment:6 Changed on 03/22/2018 at 05:51:19 PM by sebastian
- Blocking 6476 added
comment:7 Changed on 03/23/2018 at 03:41:04 PM by sebastian
- Blocking 6476 removed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6512 - Add notifications.clicked listener