Opened on 03/28/2018 at 08:36:32 PM
Closed on 03/29/2018 at 08:47:01 AM
#6535 closed change (duplicate)
Ignore libadblockplus and libadblockplus-android files
Reported by: | diegocarloslima | Assignee: | diegocarloslima |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Adblock-Plus-for-Chromium | Keywords: | |
Cc: | anton | Blocked By: | |
Blocking: | Platform: | Android | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
When building ABP Chromium, lots of files fetched from libadblockplus and libadblockplus-andoid dependencies show as unstaged files. This makes harder to use UI tools (e.g. SourceTree or GitKraken) and makes easier to add some of those files to the repository by mistake. Furthermore, it seems that it also can impact on sync calls, which can result in files being wiped and re-downloaded on each sync.
What to change
Ignore fetched files for libadblockplus and libadblockplus-android dependencies
Attachments (0)
Change History (3)
Note: See
TracTickets for help on using
tickets.
For fixing that, 2 approaches comes into my mind:
This approach has the drawback to be prone to need more maintenance in the .gitignorefile
For me, this is the best option, since we just need to add 2 rules and this is also how its done in Chromium already for other dependencies.