Opened on 03/29/2018 at 08:02:03 AM
Closed on 04/05/2018 at 07:15:57 AM
Last modified on 04/13/2018 at 10:42:43 AM
#6536 closed change (fixed)
Separate AdblockChromium files and SDK libraries files
| Reported by: | asmirnov | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Adblock-Plus-for-Chromium | Keywords: | |
| Cc: | diegocarloslima | Blocked By: | |
| Blocking: | Platform: | Android | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/chromium/merge_requests/11 |
||
Description (last modified by asmirnov)
Background
We've added build config files (BUILD.gn) and some other files (python hooks) in third_party/libadblockplus, third_party/libadblockplus_common and third_party/libadblockplus_android. However we also clone libs sources to the same directories directly. So we're mixing files from AdblockPlusChromium repository and from github libraries repositories. It makes git status show files from AdblockPlusChromium repository showing as untracked files.
The good practise is to checkout libraries files to src subdirectories and exclude them from git tracking (.gitignore) in AdblockPlusChromium repository. It will simplify gclient sync too.
What to change
Checkout paths and build configs to use src for libraries files checked out from Github.
Tips for testers
Since it does not relate to any feature it's hard to test it (i'd say you can't test if you are not developer).
If Chromium can be compiled and launched it means it did not break it at least.
Attachments (0)
Change History (5)
comment:1 Changed on 03/29/2018 at 08:42:23 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/29/2018 at 08:47:23 AM by asmirnov
comment:3 Changed on 04/05/2018 at 07:15:57 AM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 04/05/2018 at 07:39:47 AM by asmirnov
Since now they libadblockplus and libadblockplus-android are now extracted to src subdirectories i'd suggest to clean third_party/libadblockplus and third_party/libadblockplus_android, check out them again and then gclient sync.
Duplicates #6535