Opened on 04/09/2018 at 03:21:55 PM
Closed on 04/20/2018 at 12:09:45 PM
Last modified on 05/14/2018 at 09:14:49 AM
#6567 closed change (fixed)
Update buildtools dependency to 47429f8d9b6a / bd1a0d2
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.1-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | kzar, sebastian, Ross, philll | Blocked By: | #6552, #6563 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by tlucas)
Background
With #6563, we fixed a regression where developmentbuilds would not contain the buildnumber in their "addonVersion".
We now want this change to actually affect adblockpluschrome.
Additionally, we are planning to support arbitrary parameter-rendering from a metadata-file to an extensions manifest in #6552. We also want this to be included.
Included changes in buildtools
The list of changes imported by this is:
| 30b4e987f025 | Noissue - Replaced mistakenly used GPL license headers with MPL | Sebastian Noack |
| 7ee9ad9b9390 | Noissue - Prepare for absolute paths in flake8-per-file-ignores 0.5 | Sebastian Noack |
What to change
Update the buildtools dependency to:
| mercurial | git |
| 47429f8d9b6a | bd1a0d2 |
The relevant changes are #6563 and #6552.
In order to integrate the changes of #6552, move permissions, devtools and managedStorageSchema in metadata.chrome into a new manifest-section:
[manifest] devtools_page = devtools.html storage.managed_schema = managed-storage-schema.json permissions = tabs <all_urls> contextMenus webRequest webRequestBlocking webNavigation storage unlimitedStorage notifications
Additionally, replace all spaces in metadata.chrome, metadata.gecko and metadata.edge, which are supposed to separate values of a list, with newlines (with the first item of a list also starting in a newline after the option).
Hints for testers
See #6563 for information on how to test the new desired behavior (i.e. the exact revision-number should now be present)
#6552 should have no impact on the generated build.
Attachments (0)
Change History (13)
comment:1 Changed on 04/09/2018 at 09:51:28 PM by tlucas
- Description modified (diff)
- Summary changed from Update buildtools dependency to XXXXXXXXXXX to Update buildtools dependency to b05b5f5ec72c
comment:2 Changed on 04/09/2018 at 10:00:53 PM by sebastian
comment:3 Changed on 04/10/2018 at 08:32:00 AM by tlucas
- Blocked By 6552 added
- Description modified (diff)
- Summary changed from Update buildtools dependency to b05b5f5ec72c to Update buildtools dependency to ??????????
Both mentioned issues are not crucial for releases - so yes, we might as well wait for #6552.
comment:4 Changed on 04/19/2018 at 12:10:08 PM by tlucas
- Description modified (diff)
- Summary changed from Update buildtools dependency to ?????????? to Update buildtools dependency to 8055aac42982 / 9667235
comment:5 Changed on 04/19/2018 at 12:11:16 PM by sebastian
- Priority changed from Unknown to P2
- Ready set
comment:6 Changed on 04/19/2018 at 12:30:02 PM by tlucas
- Owner set to tlucas
comment:7 Changed on 04/19/2018 at 12:36:58 PM by tlucas
- Description modified (diff)
- Summary changed from Update buildtools dependency to 8055aac42982 / 9667235 to Update buildtools dependency to 47429f8d9b6a / bd1a0d2
comment:9 Changed on 04/19/2018 at 01:10:43 PM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:10 Changed on 04/20/2018 at 12:09:00 PM by abpbot
A commit referencing this issue has landed:
Issue 6567 - Update buildtools to 47429f8d9b6a
comment:11 Changed on 04/20/2018 at 12:09:45 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:12 Changed on 05/04/2018 at 02:40:25 PM by sebastian
- Milestone set to Adblock-Plus-3.1-for-Chrome-Opera-Firefox
comment:13 Changed on 05/14/2018 at 09:14:49 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. The addonVersion issues is corrected and the manifest changes seem to work as expected.
ABP 3.0.4.2044
Firefox 59 / 55 / 51 / Windows 10
Chrome 66 / 58 / 49 / Windows 7
Opera 52 / 45 / 36 / Windows 10
I wonder whether we should also wait for #6552 before updating the dependency.