Opened on 04/16/2018 at 10:58:49 AM
Closed on 04/20/2018 at 05:53:37 PM
#6590 closed change (fixed)
Update to use eyeo v8 repository
| Reported by: | asmirnov | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Adblock-Plus-for-Chromium | Keywords: | |
| Cc: | sergz, darkue | Blocked By: | |
| Blocking: | Platform: | Android | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
As i part of #6396 i had to create my own V8 repo and patch v8 build files. However we should use eyeo v8 repository for this.
What to change
Update DEPS file to use eyeo v8 repo.
Attachments (0)
Change History (3)
comment:1 Changed on 04/20/2018 at 10:15:47 AM by sergz
- Cc sergz darkue added
- Priority changed from P4 to P2
comment:2 Changed on 04/20/2018 at 05:53:22 PM by asmirnov
Since we've moved the changes to eyeo repository (https://gitlab.com/eyeo/adblockplus/chromium/commit/15112b7ac6c358d1026e339d1abf74054a1bdae9) this is not actual any more.
comment:3 Changed on 04/20/2018 at 05:53:37 PM by asmirnov
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
I have changed the priority to P2 (though perhaps it should be even P1) because we are sharing this code with third-parties and it's very highly desired to not link anyhow private repositories.