Opened on 04/17/2018 at 08:40:45 AM
Closed on 04/24/2018 at 08:00:31 AM
Last modified on 04/25/2018 at 03:41:24 PM
#6591 closed change (fixed)
Bundle ABP for Samsung Internet China with Easylist for China
| Reported by: | mario | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Samsung-Browser-1.1.5 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | vickyyu | Blocked By: | |
| Blocking: | Platform: | Samsung Browser | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by mario)
Background
As per Ticket 4699 (not public) we've prepared ABP for Samsung Internet to be distributed in China. For this, the Chinese version of ABP got a different App ID in order to be able to distribute it in app stores (GALAXY app store) where it is already listed.
As per Ticket 3804 (not public) we provide a separate filter list for China which will be automatically downloaded by Chinese users after running the app. However, since we now have a special build for China, we want to pre-bundle this build with the Chinese filter list.
What to change
Adjust build automation for the build with the App ID org.adblockplus.adblockplussbrowser.cn so it bundles the app with the Chinese version of EasyList.
Hint for testers
ABP/SI for China will be pre-bundled with this filterlist. So it's sufficient to test this filter list against the following test cases:
The whitelisting filter list rules can be tested by visiting the following websites, playing videos and observing whether a pre-roll ad is played upon starting the video:
http://tv.sohu.com
http://v.qq.com
http://iqiyi.com
http://youku.com
http://movie.douban.com
http://bilibili.com
http://cntv.cn
http://v.baidu.com
http://le.com
http://360kan.com
http://1905.com
http://dy2018.com
http://tv.cntv.cn
http://pptv.com
http://mtime.com
http://tudou.com
http://56.com
http://xunlei.com
http://v.ifeng.com
http://baofeng.com
http://mgtv.com
If the whitelisting rules are applied, pre-roll video ads ought to be shown.
Attachments (0)
Change History (9)
comment:2 Changed on 04/20/2018 at 01:23:24 PM by diegocarloslima
- Owner set to diegocarloslima
- Ready set
comment:3 Changed on 04/20/2018 at 01:23:51 PM by diegocarloslima
- Description modified (diff)
- Summary changed from Bundle ABP for Samsung Internet China with Easylist for China. to Bundle ABP for Samsung Internet China with Easylist for China
comment:4 Changed on 04/20/2018 at 01:28:12 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 04/24/2018 at 07:59:45 AM by abpbot
comment:6 Changed on 04/24/2018 at 08:00:31 AM by jwangenheim
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 04/24/2018 at 08:22:59 AM by mario
- Milestone set to Adblock-Plus-for-Samsung-Browser-next
comment:9 Changed on 04/25/2018 at 03:41:24 PM by vickyyu
- Cc vickyyu added
A commit referencing this issue has landed:
Issue 6591 - Bundle ABP for Samsung Internet China with Easylist for China