Opened on 04/22/2018 at 11:24:41 AM
Closed on 04/23/2018 at 10:36:54 AM
Last modified on 05/11/2018 at 12:36:12 PM
#6607 closed change (fixed)
Update adblockpluscore dependency to hg:d7d51d29aa34
Reported by: | mjethani | Assignee: | mjethani |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Plus-3.1-for-Chrome-Opera-Firefox |
Module: | Platform | Keywords: | |
Cc: | sebastian, kzar, hfiguiere | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Ross | Verified working: | yes |
Review URL(s): |
Description
Background
There have been a few changes in adblockpluscore which should be included for the next release.
In chronological order:
- Noissue - Access document via this (168b11c79b69)
- Noissue - Use Map to store EventEmitter listeners (68f7bdc837c8)
- Noissue - Check for null and blank string instead of undefined (d0040a356cf0)
- Issue 6559 - Use maps and sets where appropriate (662384d3b0ad)
- Issue 6559 - Fix tests for changeset 662384d3b0ad (d129b3ec802a)
- Issue 6437 - Do not override scheduled full processing (1a75179cc3d0)
- Noissue - Trim spaces around element hiding emulation selectors (3e3970f86e14)
- Issue 6382 - Catch InvalidAccessError exception when checking styles. (48234147ffed)
- Issue 6437 - Apply :-abp-contains() to matching roots only (d7d51d29aa34)
What to change
Update adblockpluscore dependency to hg:d7d51d29aa34 git:8508af0
Hints for testers
- Test that element hiding emulation works in general
- Test that element hiding emulation works when Stylus is installed (#6382, #6594)
- Test that the filters ||example.com^$csp and ||example.com^$csp= don't throw any errors (see background page console and tab console)
- Test that given the HTML fragment <div id="a"><div id="b"><div id="c">Hello</div></div></div> and the filter example.com#?#div:-abp-contains(Hello), the display: none !important style is only applied to the outermost div
Attachments (0)
Change History (7)
comment:1 Changed on 04/22/2018 at 11:25:12 AM by mjethani
- Cc sebastian kzar hfiguiere added
comment:3 Changed on 04/23/2018 at 08:57:40 AM by kzar
- Priority changed from Unknown to P2
- Ready set
comment:4 Changed on 04/23/2018 at 10:33:36 AM by abpbot
comment:5 Changed on 04/23/2018 at 10:36:31 AM by mjethani
- Owner set to mjethani
comment:6 Changed on 04/23/2018 at 10:36:54 AM by mjethani
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from new to closed
comment:7 Changed on 05/11/2018 at 12:36:12 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Element hiding emulation works in general, the Stylus issue is fixed, the $csp filters do not error and the contains filter only applys display: none to the outermost div.
ABP 3.0.4.2042
Firefox 59 / 55 / 51 / Windows 10
Chrome 66 / 58 / 49 / Windows 7
Opera 52 / 45 / 36 / Windows 10
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6607 - Update adblockpluscore dependency to revision d7d51d29aa34