Opened on 04/24/2018 at 01:20:50 PM
Closed on 06/27/2018 at 09:38:17 AM
Last modified on 08/28/2018 at 12:25:07 PM
#6619 closed defect (fixed)
Element hiding emulation injects incorrect CSS selector for :-abp-properties() when the selector in the document's style sheet is a compound selector
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | circumvention |
| Cc: | kzar, hfiguiere, arthur, Ross, amrmak | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
ABP 3.0.3 on Chrome 66
How to reproduce
- Browse to https://static.kzar.co.uk/6619-test.html
- Add this filter: static.kzar.co.uk#?#div:-abp-properties(font-weight: bold;)
- Refresh the page
Observed behaviour
Both divs (div#foo and div#bar) should be hidden.
Expected behaviour
Only div#foo is hidden.
Notes
This doesn't work because the element hiding emulation code adds the prefix div to the selector body #foo so we get divbody #foo.
Attachments (0)
Change History (13)
comment:1 Changed on 04/24/2018 at 01:21:14 PM by mjethani
- Summary changed from Element hiding emulation injects incorrect selector for :-abp-properties when the selector in the document's style sheet is a compound selector to Element hiding emulation injects incorrect CSS selector for :-abp-properties() when the selector in the document's style sheet is a compound selector
comment:2 Changed on 04/24/2018 at 01:22:32 PM by mjethani
comment:3 Changed on 04/24/2018 at 01:24:38 PM by arthur
- Cc arthur added
comment:4 Changed on 04/24/2018 at 01:26:29 PM by Ross
- Cc Ross added
comment:5 Changed on 04/24/2018 at 02:03:55 PM by mjethani
- Sensitive set
comment:7 Changed on 04/24/2018 at 07:44:26 PM by amrmak
- Cc amrmak added
comment:8 Changed on 05/04/2018 at 02:42:46 PM by kzar
- Description modified (diff)
- Priority changed from Unknown to P2
- Ready set
comment:9 Changed on 06/24/2018 at 04:15:49 PM by abpbot
A commit referencing this issue has landed:
Issue 6619 - Qualify CSS selectors in document style sheet correctly
comment:10 Changed on 06/27/2018 at 09:38:08 AM by mjethani
- Owner set to mjethani
comment:11 Changed on 06/27/2018 at 09:38:17 AM by mjethani
- Resolution set to fixed
- Status changed from new to closed
comment:12 Changed on 08/16/2018 at 01:31:39 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 3.2.0.2103
Chrome 68 / 55 / 49 / Windows 10
Firefox 61 / 55 / 51 / Windows 10
comment:13 Changed on 08/28/2018 at 12:25:07 PM by sebastian
- Sensitive unset
Note: See
TracTickets for help on using
tickets.
I'm not sure how we can address this by the way but it seems like something that should work. I'm hoping we can use more element hiding emulation filters to defeat circumvention where standard CSS doesn't work.