Opened on 05/05/2018 at 08:18:42 AM
Closed on 05/06/2018 at 10:36:46 PM
#6650 closed defect (duplicate)
Update buildtools dependency to 168dac24ad9e
Reported by: | tlucas | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Platform | Keywords: | |
Cc: | sebastian, kzar, geo, oleksandr | Blocked By: | |
Blocking: | #6621 | Platform: | Unknown / Cross platform |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
In #6635, we introduced the exposure of webpack's resolve.alias-machinery. In order to solve #6621, we need this in adblockpluschrome.
Included changes in buildtools
The list of changes imported by this is:
Ticket | Summary | Component |
---|---|---|
#6625 | Enable module switching in webpack, parametrized by metadata.* | Automation |
a8b5bbe92c0a | Noissue - Adapt best practices for trailing commas | Sebastian Noack |
What to change
Update the buildtools dependency to:
mercurial | git |
168dac24ad9e | f679caf |
According to #6625, include resolve.alias and it's documentation in the repositories README.md.
Hints for testers
The builds should not have changed at all.
Attachments (0)
Change History (5)
comment:1 Changed on 05/05/2018 at 08:26:05 AM by tlucas
- Cc sebastian kzar geo oleksandr added
comment:2 Changed on 05/05/2018 at 01:56:56 PM by sebastian
comment:3 Changed on 05/05/2018 at 02:02:33 PM by tlucas
Geo and i got it running yesterday, so from my point of view we're all good.
I wouldn't mind the implicit update with #6621 either - what do you think, Geo?
In case we all agree here, i'll close this ticket. (@Geo, feel free to contact me again if you need any support)
As long as these are the only new changes in buildtools, I'm fine with performing the dependency update implicitly as part of #6621. Before #6621 lands, this dependency update won't have any effect on the builds anyway, and that way we can also validate that the changed done for #6625 are sufficient.
FWIW, geo failed so far to use the module switching mechanism introduced in #6625. Perhaps you can show her a working example similar to what we want to do in #6621.