$genericblock filter applies to domain specific filter

[Ross]

Environment

ABP 3.0.4.2042
Chrome 66 / Windows 10
Firefox 59 / Windows 10

Could not reproduce with ABP 3.0.3

How to reproduce

1. Add a generic blocking filter *.png*.svg
2. Add a $genericblock exception @@||adblockplus.org^$genericblock
3. Comment out the $genericblock filter.
4. Replace generic blocking filters with domain specific filters ||adblockplus.org/img/navbar-logo.png ||adblockplus.org/img/navbar-logo.svg
5. Uncomment the $genericblock filter.

Observed behaviour

With generic blocking filters: Logo blocked.
With generic blocking filters + $genericblock: Logo not blocked.
With specific blocking filters: Logo blocked.
With specific blocking filters + $genericblock: Logo not blocked (bug)..

Expected behaviour

The $genericblock filter should not prevent the domain specific filters from being applied to the page.

[mapx]

Probably genericblock option could be removed (used only for 2 sites in easylist) when the snippet filters will land in ABP. For 1 genericblock filter other "n" have to be added to block back what was whitelisted. Too heavy.

[sebastian]

Well, the filters ||adblockplus.org/img/navbar-logo.png and ||adblockplus.org/img/navbar-logo.svg aren't meant to be considered domain-specific but generic as well. Only filters with a $domain option are considered domain-specific, while any blocking filter without $domain option should be disabled when $genericblock is in effect. Or do I miss something?

[Ross]

Ah. Okay, I did not know/realise that. That said, the behaviour is different from 3.0.3, unless I missed something also.

[sebastian]

So if the behavior changed as described here, it was broken before, and working correctly now. However, when I try to reproduce it, 3.0.3 and the current devbuild behaves the same.