Opened on 05/11/2018 at 01:19:26 PM

Closed on 05/29/2018 at 04:49:06 PM

Last modified on 07/09/2018 at 01:00:35 PM

#6661 closed change (fixed)

Localize date in the Filter Lists section of options page

Reported by: saroyanm Assignee: saroyanm
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockplusui/merge_requests/14

Attachments (0)

Change History (11)

comment:1 Changed on 05/11/2018 at 01:22:35 PM by saroyanm

@greiner, @wspee: as I've mentioned here I wasn't sure if this is the right way to do it and @greiner confirmed here we should use trac issue.

Please let me know if current Trac issue description, looks good enough, also would be great to have some example of trac ticket referencing Gitlab implementation, to make it easy Trac reference ticket creation.

comment:2 Changed on 05/11/2018 at 02:07:01 PM by greiner

For reference, here are two previous tickets I've created to reference GitLab issues: #6658, #6659

comment:3 follow-up: Changed on 05/11/2018 at 02:27:17 PM by saroyanm

  • Description modified (diff)

Thanks Thomas I like the way #6658 is formated.

comment:4 in reply to: ↑ 3 Changed on 05/11/2018 at 03:57:56 PM by greiner

Replying to saroyanm:

Thanks Thomas I like the way #6658 is formated.

Note that under "What to change" I'm referring to the spec merge request, not to the UI merge request because that'd be a circular reference.

comment:5 Changed on 05/11/2018 at 05:10:09 PM by saroyanm

  • Description modified (diff)

Noted.

comment:6 Changed on 05/11/2018 at 09:13:46 PM by saroyanm

  • Description modified (diff)

comment:7 Changed on 05/29/2018 at 04:48:54 PM by saroyanm

  • Owner set to saroyanm

comment:8 Changed on 05/29/2018 at 04:49:00 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed on 05/29/2018 at 04:49:06 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed on 05/30/2018 at 02:56:12 PM by abpbot

A commit referencing this issue has landed:
Issue 6661 - Localized date in the filter lists section

comment:11 Changed on 07/09/2018 at 01:00:35 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Appears to be working as expected.

ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.