Opened on 05/18/2018 at 07:08:09 AM

Closed on 07/10/2018 at 04:01:04 PM

Last modified on 07/11/2018 at 09:55:53 AM

#6681 closed change (fixed)

[Gitlab CI] Add linting for a .gitlab-ci.yml

Reported by: tlucas Assignee:
Priority: P3 Milestone:
Module: Automation Keywords: gitlab, ci
Cc: sebastian, kzar, matze Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29825579/

Description (last modified by tlucas)

Background

In #6651 we started discussing how we would implement CI for adblockpluschrome. Currently, we'll most likely stick to gitlab.

In order to get this going, we want to be able to lint the configuration file before invoking a pipeline.

What to change

  • Add a command lint-gitlab-ci to build.py, which should look for a .gitlab-ci.yml in the tree and validate it as described here
  • Adjust the README.md to mention PyYAML as a dependency, if one wants to lint a .gitlab-ci.yml file.

Attachments (0)

Change History (4)

comment:1 Changed on 05/18/2018 at 12:30:49 PM by tlucas

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 07/10/2018 at 04:00:31 PM by abpbot

A commit referencing this issue has landed:
Issue 6681 - Add linting for .gitlab-ci.yml

comment:3 Changed on 07/10/2018 at 04:01:04 PM by tlucas

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed on 07/11/2018 at 09:55:53 AM by tlucas

  • Review URL(s) modified (diff)

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.