Opened on 05/18/2018 at 07:30:00 AM
Closed on 10/08/2018 at 03:54:43 PM
#6682 closed change (fixed)
[Gitlab CI] Automate (unsigned) development build creation of Adblock Plus
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | gitlab, ci |
| Cc: | sebastian, kzar, matze, fhd | Blocked By: | #7004 |
| Blocking: | #7020 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by tlucas)
Background
In #6651, we introduced CI for adblockpluschrome with gitlab-ci. This enables us to implement a first approach for CD for Adblock Plus, which is also part of Priority Experiment 3.
What to change
Add the jobs build:{gecko|chrome|edge} to the .gitlab-ci.yml in adblockpluschrome, which should create unsigned builds for the respective platforms, only when the master branch is updated and store them as the job's artifact.
Note: While #7024 is not fixed, invalid or rejected, the target edge must be allowed to fail gracefully.
Pulled in changes
This issues involves updating buildtools to
| hg | git |
| 59a519c38766 | 9342139 |
pulling in the change for #7004 only.
Attachments (0)
Change History (14)
comment:1 Changed on 10/04/2018 at 02:13:59 PM by tlucas
- Description modified (diff)
- Priority changed from Unknown to P1
- Ready set
- Summary changed from [Gitlab CI] Move uploading logic from abpssembly to the buildtools to [Gitlab CI] Automate deployment of Adblock Plus for Firefox development builds
comment:2 Changed on 10/04/2018 at 02:18:34 PM by tlucas
- Blocking 7020 added
comment:3 Changed on 10/04/2018 at 02:30:53 PM by tlucas
- Priority changed from P1 to P2
comment:6 Changed on 10/06/2018 at 09:33:57 AM by tlucas
- Blocked By 7004 added
comment:7 Changed on 10/08/2018 at 12:43:56 PM by tlucas
- Description modified (diff)
- Owner set to tlucas
comment:8 Changed on 10/08/2018 at 12:48:03 PM by tlucas
- Description modified (diff)
- Summary changed from [Gitlab CI] Automate deployment of Adblock Plus for Firefox development builds to [Gitlab CI] Automate (unsigned) development build creation of Adblock Plus
comment:9 Changed on 10/08/2018 at 01:30:09 PM by sebastian
comment:10 Changed on 10/08/2018 at 01:39:41 PM by tlucas
- Description modified (diff)
comment:11 Changed on 10/08/2018 at 02:31:13 PM by tlucas
- Description modified (diff)
comment:12 Changed on 10/08/2018 at 03:07:18 PM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:13 Changed on 10/08/2018 at 03:54:11 PM by abpbot
Some commits referencing this issue have landed:
comment:14 Changed on 10/08/2018 at 03:54:43 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Should we limit this to the master branch? Since this is what we want to make development builds available for?