Opened on 05/18/2018 at 08:46:54 AM
Last modified on 03/20/2019 at 05:23:20 PM
#6683 new defect
Orca crashes when logging in to Discourse
Reported by: | jwangenheim | Assignee: | |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Adblock-Plus-for-Chromium | Keywords: | |
Cc: | Anton | Blocked By: | |
Blocking: | Platform: | Android | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Environment
Google Pixel C
Latest build of Orca (0.1.2)
Adblocking enabled. With adblocking disabled, the app does not crash.
How to reproduce
- visit http://intraforum.adblockplus.org/
- tap login (takes you through GoogleApps login)
- type in your email and password, and hit login
- the callback automatically takes you back to Discourse
Observed behaviour
Orca crashes
Expected behaviour
Orca should not crash but redirect to Discourse
Attachments (4)
Change History (12)
Changed on 05/18/2018 at 08:47:02 AM by jwangenheim
comment:1 Changed on 05/18/2018 at 09:55:29 AM by asmirnov
comment:2 follow-up: ↓ 3 Changed on 05/18/2018 at 10:02:56 AM by asmirnov
i can't reproduce it (having two-factor authentication, so one more step is added after typing password) with AbpChromium fbc09406b939da668ad97c1f2d9258905818ac7d
comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed on 05/18/2018 at 10:09:13 AM by jwangenheim
Replying to asmirnov:
i can't reproduce it (having two-factor authentication, so one more step is added after typing password) with AbpChromium fbc09406b939da668ad97c1f2d9258905818ac7d
I've tried it with the AbpChromium version I've got installed on my phone (15112b7ac6c358d1026e339d1abf74054a1bdae9) and can reproduce it.
comment:4 in reply to: ↑ 3 ; follow-up: ↓ 5 Changed on 05/18/2018 at 10:15:22 AM by asmirnov
Replying to jwangenheim:
Replying to asmirnov:
i can't reproduce it (having two-factor authentication, so one more step is added after typing password) with AbpChromium fbc09406b939da668ad97c1f2d9258905818ac7d
I've tried it with the AbpChromium version I've got installed on my phone (15112b7ac6c358d1026e339d1abf74054a1bdae9) and can reproduce it.
Do you also have two-factor auth?
comment:5 in reply to: ↑ 4 Changed on 05/18/2018 at 10:36:09 AM by jwangenheim
Replying to asmirnov:
Replying to jwangenheim:
Replying to asmirnov:
i can't reproduce it (having two-factor authentication, so one more step is added after typing password) with AbpChromium fbc09406b939da668ad97c1f2d9258905818ac7d
I've tried it with the AbpChromium version I've got installed on my phone (15112b7ac6c358d1026e339d1abf74054a1bdae9) and can reproduce it.
Do you also have two-factor auth?
Yes, I do.
comment:6 Changed on 05/18/2018 at 10:40:53 AM by asmirnov
i've tested 15112b7ac6c358d1026e339d1abf74054a1bdae9 with two-factor auth and i can't reproduce.
Changed on 05/18/2018 at 10:41:35 AM by asmirnov
no crash log for me
Changed on 05/18/2018 at 10:41:51 AM by asmirnov
no crash screenshot for me
comment:7 Changed on 05/18/2018 at 10:47:53 AM by asmirnov
According to the log (can see Adblock: element hiding - generated JS but no Adblock: element hiding - called JS) and the sources i can imagine that frameHost is nullptr:
https://gitlab.com/eyeo/adblockplus/chromium/blob/96ed84b4a7fcbf0b3436d186c0a8fc7ae3888c99/chrome/browser/android/adblock/adblock_bridge.cc#L163
webContents can't be nullptr as it would crash earlier:
https://gitlab.com/eyeo/adblockplus/chromium/blob/96ed84b4a7fcbf0b3436d186c0a8fc7ae3888c99/chrome/browser/android/adblock/adblock_bridge.cc#L143
So it looks like Chromium bug then..
Changed on 05/23/2018 at 12:28:20 PM by asmirnov
comment:8 Changed on 03/20/2019 at 05:23:20 PM by aboegler
I'm no longer experiencing this crash with Orca 0.4.0 and 0.5.0.
attached log part: