Opened on 05/28/2018 at 09:08:27 AM

Closed on 09/05/2019 at 05:01:31 PM

#6700 closed defect (duplicate)

Count in ABP icon is incorrect when a high number of ads are blocked

Reported by: rscott Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner, kzar, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Environment

ABP 3.1
Enabled filter lists: easylist.txt

How to reproduce

  1. Download the attached file, which contains 10,000 blockable image elements.
  2. Open the page in your browser, with ABP enabled and the count of blocked ads in its icon turned on.

Observed behaviour

In FF 60.0.1/Ubuntu 64-bit:

  • Count of blocked ads is truncated to the first four digits. (Shows '1000' after the page finishes loading.)

in Chromium 66/Ubuntu 64-bit:

  • Count of blocked ads falls short of 10,000. On my system, it stops at somewhere between 6,200 and 6,900, although it varies between pageloads.

Expected behaviour

Count should display 10000.

What to change

See ​ui#222.

Attachments (1)

10k-ads.html​ (448.5 KB) - added by rscott on 05/28/2018 at 09:09:01 AM.

Download all attachments as: .zip

Change History (6)

Changed on 05/28/2018 at 09:09:01 AM by rscott

comment:1 follow-up: Changed on 07/24/2018 at 03:33:14 PM by kzar

  • Cc greiner kzar added
  • Component changed from Platform to User-Interface

I think this might come under the UI module, what do you think Thomas?

comment:2 in reply to: ↑ 1 Changed on 07/24/2018 at 05:07:03 PM by greiner

Replying to kzar:

I think this might come under the UI module, what do you think Thomas?

I see what you mean because lib/stats.js is only used for the UI even though it's part of Platform according to ​adblockplus.org/modules.

I'd be fine with either as long as it is clear who should be responsible for it so whichever you think works best for you guys.

comment:3 Changed on 07/24/2018 at 07:10:50 PM by kzar

  • Cc sebastian added

I'm easy as well. Any objection if we move lib/stats.js into the User-Interface module Sebastian?

comment:4 Changed on 10/10/2018 at 12:48:38 PM by greiner

  • Description modified (diff)

Added link to GitLab issue.

comment:5 Changed on 09/05/2019 at 05:01:31 PM by greiner

  • Resolution set to duplicate
  • Status changed from new to closed

Closing this ticket in favor of ​ui#222.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.