Opened on 05/28/2018 at 04:02:51 PM
Closed on 07/06/2018 at 05:08:06 PM
#6701 closed change (fixed)
Implement CSP support in python-abp
| Reported by: | kvas | Assignee: | rhowell |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kvas)
Background
ABP now supports filters that inject a Content Security Policy via $csp option (see documentation here, implemented by #5241, #6329). Python-abp should also support this option.
What to change
Implement parsing of $csp option. Python-abp doesn't interpret the options (it does not compute the resulting resource type masks or anything like that) so $csp should simply be handled as an option with a value or, when negated (the doc doesn't mention this, but there's a test for it in abpcore tests), it should get the value of False.
Notes:
- Filter normalization is not part of this ticket.
References:
- CSP docs on Mozilla website -- probably not really needed, but just in case.
- The tests of adblockpluscore change can be used as an inspiration for this.
Attachments (0)
Change History (5)
comment:2 Changed on 05/29/2018 at 04:55:54 PM by rhowell
- Owner set to rhowell
- Ready set
- Review URL(s) modified (diff)
comment:3 Changed on 05/30/2018 at 12:36:17 PM by kvas
- Priority changed from Unknown to P3
- Status changed from new to reviewing
comment:4 Changed on 06/18/2018 at 08:30:47 PM by abpbot
comment:5 Changed on 07/06/2018 at 05:08:06 PM by rhowell
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6701 - Implement CSP support in python-abp