Opened on 06/06/2018 at 04:26:49 PM
Closed on 08/28/2018 at 12:43:55 PM
Last modified on 10/19/2018 at 09:47:08 AM
#6736 closed change (fixed)
Make Show useful notifications option persistent on the advanced tab of the options page
Reported by: | saroyanm | Assignee: | saroyanm |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | User-Interface | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #6892 | Platform: | Unknown / Cross platform |
Ready: | yes | Confidential: | no |
Tester: | Ross | Verified working: | yes |
Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/33 |
Description
Background
See -> https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/102
What to change
See -> https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/102
Attachments (0)
Change History (7)
comment:1 Changed on 06/06/2018 at 04:27:06 PM by saroyanm
- Summary changed from Make Show useful notifications persistent on the advanced tab of the options page to Make Show useful notifications option persistent on the advanced tab of the options page
comment:2 Changed on 08/28/2018 at 12:25:16 PM by greiner
- Blocking 6892 added
comment:3 Changed on 08/28/2018 at 12:43:26 PM by greiner
- Owner set to saroyanm
comment:4 Changed on 08/28/2018 at 12:43:37 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 08/28/2018 at 12:43:55 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 09/13/2018 at 10:30:21 AM by abpbot
A commit referencing this issue has landed:
Issue 6736 - Make 'Show useful notifications' option persistent
comment:7 Changed on 10/19/2018 at 09:47:08 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Show useful notifications checkbox is always shown on the options page.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
Note: See
TracTickets for help on using
tickets.
Done: https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/67c89ced88cd7c4aa51f0c250fff6ab32f67f513