Opened on 06/09/2018 at 12:49:05 PM
Closed on 08/29/2019 at 05:43:52 PM
#6741 closed change (rejected)
Use ECMAScript 2015 classes
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | sergz, kzar, jsonesen | Blocked By: | #7001 |
| Blocking: | #6482 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29803559/ |
||
Description (last modified by mjethani)
Background
See #6482.
What to change
Convert "classes" everywhere in the Core module to ES 2015 classes, and update the JSDoc comments accordingly to remove redundant @constructor and similar tags.
Hints for testers
The changes until changeset 4520c259dbcf should have no impact on current behavior. Make sure that filter list downloads and element hiding emulation work as expected in general (no specific recommendations).
For the dependency update in #6933, there are no specific things to test as there is no change in behavior or implementation details.
Attachments (0)
Change History (17)
comment:1 Changed on 06/09/2018 at 12:49:53 PM by mjethani
- Priority changed from P3 to P4
comment:2 Changed on 06/09/2018 at 12:51:53 PM by mjethani
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 08/14/2018 at 11:44:29 PM by jsonesen
- Cc jsonesen added
comment:6 Changed on 08/21/2018 at 02:57:50 PM by abpbot
comment:7 Changed on 08/21/2018 at 06:43:12 PM by abpbot
A commit referencing this issue has landed:
Issue 6741 - Use ES2015 classes in lib/events.js
comment:9 Changed on 08/27/2018 at 09:49:15 PM by abpbot
A commit referencing this issue has landed:
Issue 6741 - Use ES2015 classes in lib/downloader.js
comment:10 Changed on 08/28/2018 at 08:27:51 AM by mjethani
- Description modified (diff)
comment:11 Changed on 08/30/2018 at 03:59:41 PM by jsonesen
- Review URL(s) modified (diff)
comment:12 Changed on 09/04/2018 at 05:26:53 PM by abpbot
A commit referencing this issue has landed:
Issue 6741 - Use ES2015 classes in lib/synchronizer.js
comment:13 Changed on 09/07/2018 at 03:20:00 AM by abpbot
A commit referencing this issue has landed:
Issue 6741 - Use ES2015 classes in lib/matcher.js
comment:14 Changed on 09/11/2018 at 01:46:37 PM by mjethani
- Description modified (diff)
comment:15 Changed on 09/28/2018 at 11:04:23 PM by mjethani
- Blocked By 7001 added
comment:16 Changed on 10/23/2018 at 02:35:38 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Element hiding emulation is still working as expected.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
comment:17 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from reviewing to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
A commit referencing this issue has landed:
Issue 6741 - Use ES2015 classes in lib/content/elemHideEmulation.js