Update adblockpluscore to dcda4859fcbd (and adblockplusui for compatibility)

[greiner]

Background

This dependency update pulls in following changes from adblockpluscore:

• #6741 - Use ECMAScript 2015 classes (changesets ​4520c259dbcf, ​cd488181bf4f, ​bb99b7ba5b05, and ​84ea8a5e3951)
• #6870 - Remove support for legacy :-abp-properties() syntax
• #6893 - Split out the INIParser class into its own file
• #6854 - Remove deprecated FilterNotifier methods
• #6891 - Properly distinguish objects from classes (changeset ​4ac82a57f7bd)
• #6862 - Make Snippets module emit events
• #6883 - Use filterToRegExp in lib/filterClasses.js
• #6919 - Implement hide-if-contains-and-matches-style snippet
• #6916 - Avoid Set object for filters with only one subscription
• #6868 - Rewrite filter with wildcard doesn't match end of URL
• #6908 - Pass updated subscription's old filters as an event argument
• #6927 - Expose pattern from RegExpFilter
• #6931 - localhost isn't considered a domain by content filter validating code
• #6923 - Only parse metadata from special comments at the top of the file

For compatibility we have to simultaneously pull in following changes from adblockplusui:

Ticket	Status	Resolution	Summary	Component	Owner
#6876	closed	fixed	Update code to work with Filter.prototype.subscriptions as a Set object	User-Interface	greiner
#6907	closed	fixed	Adapt code to ensure compatibility with latest changes to filter notifier	User-Interface	greiner
#6921	closed	worksforme	Adapt code to work with latest changes to filter prototype	User-Interface	greiner

What to change

• Change adblockplusui dependency to hg:b6392804edfe git:cb795db.
• Change adblockpluscore dependency to hg:dcda4859fcbd git:c9dc573.
• Adapt for the changes in #6907 and #6916 (see the respective integration notes).

Hints for testers

See hints for testers section in the individual tickets. If the necessary information is missing, please leave a comment asking for details/clarification.

[greiner]

I've created this ticket for the simultaneous update of the Core and UI dependencies.

As the UI changes depend on which Core changes will end up making it into the next release, they haven't been pushed to Mercurial yet. However, as soon as we know which Core revision we want to update to, we'll also be able to finalize the UI changes and push them live.

[sebastian]

We would want to update to whatever the latest revision of master@adblockpluscore will be at the time. But I don't expect any further changes landing that will require changes to the UI.

[mjethani]

Replying to sebastian:

But I don't expect any further changes landing that will require changes to the UI.

If we're going into code freeze for ABP 3.4 soon, we can commit to not making any more breaking changes to core. When we update the dependency, we'll branch off core into a new next branch as decided previously.

[greiner]

Added revisions.

[abpbot]

A commit referencing this issue has landed:
​Issue 6933 - Update adblockpluscore dependency to hg:dcda4859fcbd

[mjethani]

The above change was landed on the next branch, is it going to make it to master and the development builds?

[sebastian]

Yes, I will merge next into master soon (development builds are built from master).

I'm mostly just waiting for the dependency update that pulls in the remaining changes (and related translations) from adblockplusui before we can start testing.

The reason I don't merge next into master yet, is once we do we will be unable to do any further snippet-only or hotfix releases. So I wait until we actually start testing for 3.4.

[Ross]

This can be verified now.

ABP 3.3.2.2176
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10