Opened on 06/25/2018 at 10:02:47 PM
Last modified on 10/25/2018 at 12:42:04 PM
#6764 new defect
Building of libadblockplus target does not respect ABP_TARGET_ARCH arg
Reported by: | asmirnov | Assignee: | |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Libadblockplus | Keywords: | |
Cc: | sergz, hub | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Environment
Adblockplus is built while building of AblockChromium. In order to build faster we try to avoid building of unneeded components.
args = [ "/usr/bin/make", "-j8", # cwd "--cwd${_abs_libadblockplus_dir}", # environment variables "--envSKIP_DEPENDENCY_UPDATES=true", "--envANDROID_NDK_ROOT=${_abs_libadblockplus_dir}/third_party/android-ndk-r16b", "--envTARGET_OS=android", "--envSUB_ACTION=libadblockplus", "--envABP_TARGET_ARCH=${v8_abi_dir}", "--envConfiguration=release", "--envBUILD_DIR=${_abs_libadblockplus_prebuild_dir}", # v8 "--envLIBV8_INCLUDE_DIR=${_abs_v8_include_dir}", "--envSTATIC_V8_LIB_DIR=${_abs_v8_libraries_dir}" ] print(args) exec_script("//third_party/libadblockplus_common/subproc.py", args)
How to reproduce
$ rm -rf /home/anton/adblockchromium/src/out/Debug/obj/third_party/libadblockplus_android/prebuild_libadblockplus anton@dell-XPS-13-9370:~/adblockchromium/src$ gn gen --args='target_os="android" is_debug=true proprietary_codecs=true ffmpeg_branding="Chrome"' out/Debug ["/usr/bin/make", "-j8", "--cwd/home/anton/adblockchromium/src/third_party/libadblockplus/src", "--envSKIP_DEPENDENCY_UPDATES=true", "--envANDROID_NDK_ROOT=/home/anton/adblockchromium/src/third_party/libadblockplus/src/third_party/android-ndk-r16b", "--envTARGET_OS=android", "--envSUB_ACTION=libadblockplus", "--envABP_TARGET_ARCH=arm", "--envConfiguration=release", "--envBUILD_DIR=/home/anton/adblockchromium/src/out/Debug/obj/third_party/libadblockplus_android/prebuild_libadblockplus", "--envLIBV8_INCLUDE_DIR=/home/anton/adblockchromium/src/v8/include", "--envSTATIC_V8_LIB_DIR=/home/anton/adblockchromium/src/third_party/libadblockplus/src/third_party/prebuilt-v8/android-arm-release"] anton@dell-XPS-13-9370:~/adblockchromium/src$ ls /home/anton/adblockchromium/src/out/Debug/obj/third_party/libadblockplus_android/prebuild_libadblockplus/out/Release/ libadblockplus.a obj.target $ find /home/anton/adblockchromium/src/out/Debug/obj/third_party/libadblockplus_android/prebuild_libadblockplus/out/Release -name *.o .. /home/anton/adblockchromium/src/out/Debug/obj/third_party/libadblockplus_android/prebuild_libadblockplus/out/Release/obj.target/libadblockplus/src/DefaultFileSystem.o /home/anton/adblockchromium/src/out/Debug/obj/third_party/libadblockplus_android/prebuild_libadblockplus/out/Release/obj.target/libadblockplus/src/WebRequestJsObject.o c$ file /home/anton/adblockchromium/src/out/Debug/obj/third_party/libadblockplus_android/prebuild_libadblockplus/out/Release/obj.target/libadblockplus/src/WebRequestJsObject.o /home/anton/adblockchromium/src/out/Debug/obj/third_party/libadblockplus_android/prebuild_libadblockplus/out/Release/obj.target/libadblockplus/src/WebRequestJsObject.o: ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
Observed behaviour
x86 archive is built
Expected behaviour
arm archive is built
Attachments (0)
Change History (4)
comment:1 Changed on 06/25/2018 at 10:03:34 PM by asmirnov
- Cc hub added
comment:2 Changed on 06/26/2018 at 11:28:08 AM by asmirnov
comment:3 Changed on 10/25/2018 at 09:50:15 AM by sergz
Is it still the issue, it seems resolved.
comment:4 Changed on 10/25/2018 at 12:41:54 PM by asmirnov
I did not check it on regular basis. You have the commands to reproduce it, did you try?
Last edited on 10/25/2018 at 12:42:04 PM
by asmirnov
Note: See
TracTickets for help on using
tickets.
reproduced it from scratch on ubuntu 16.04: